enhancement(client): rename Strapi to StrapiClient #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convly
added
pr: enhancement
Convly
commented
Apr 8, 2025
alexandrebodin
approved these changes
Apr 8, 2025
Member
alexandrebodin
left a comment
alexandrebodin
left a comment
There was a problem hiding this comment.
I like it, the exports stuff could also help for testing internals potentialy by exposing the index.ts for testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
StrapitoStrapiClientto better understand its purposeStrapiConfigtoStrapiClientConfigto follow the associated class' changefilesaccessor from a getter to a property by making it public and renaming it from_filestofilesWhy is it needed?
Cleanup, improve developer experience.
How to test it?
Everything should work just like previous versions, new types should be available