Quick Fix: Firewall Dynamic Addresses Restored #280
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where dynamic addresses in the firewall were not working correctly. The main cause was a mismatch between original and remapped IP addresses during environment resets.
Main Changes
known_dataIPs from the taskfile configuration to ensure consistency.Details
Firewall Reset Issue
reset()method,self._firewallwas being restored using the original network IPs stored infirewall_original.KeyErrorwas raised because the firewall contained original IPs while the rest of the system expected remapped ones.self._firewallretains the remapped IPs during reset, preventing the mismatch and subsequent errors.Incorrect
known_dataIP Mapping in Goal Conditionscoordinator.pyrely on IPs from thetask configfile.known_dataIPs were never remapped, causing agents to exfiltrate data to the wrong internet IP instead of the one specified in the taskfile.known_dataIPs in the taskfile, ensuring consistency across all components.These changes should resolve the issue, but further testing is recommended. ✅