Skip to content

dns.py: check for whitelisted whitelist dst domains when detecting DGA #1064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlyaGomaa merged 1 commit into from
Nov 14, 2024
Merged

dns.py: check for whitelisted whitelist dst domains when detecting DGA #1064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/flowalerts/dns.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ def detect_dga(self, profileid, twid, flow):
or flow.query.endswith(".arpa")
or flow.query.endswith(".local")
or self.flowalerts.whitelist.domain_analyzer.is_whitelisted(
flow.query, Direction.SRC, "alerts"
flow.query, Direction.DST, "alerts"
)
):
return False
Expand Down
2 changes: 1 addition & 1 deletion slips_files/core/helpers/whitelist/domain_whitelist.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ def is_whitelisted(
the given domain
:param domain: domain to check if whitelisted
:param direction: is the given domain src or dst domain?
:param should_ignore: can be flows or alerts
:param should_ignore: which whitelist to check? can be flows or alerts
"""

if not isinstance(domain, str):
Expand Down