noise-sv2: add 10s clock skew tolerance to signature verification #2017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasbalieiro
force-pushed
the
add-time-tolerance-to-noise-validation
branch
from
cdc67a3 to
a461e61
Compare
Collaborator
Author
|
added 841641d which implements Display for SignatureNoiseMessage, allowing sv2-apps to show clear, human-readable info instead of raw byte dumps. Before display trait: 2025-12-02T14:16:24.691962Z ERROR translator_sv2::sv2::upstream::upstream: Failed Noise handshake with 188.40.233.17:34254: CodecError(NoiseSv2Error(InvalidCertificate([0, 0, 190, 244, 46, 105, 206, 2, 47, 105, 146, 164, 238, 218, 246, 86, 50, 46, 132, 248, 120, 123, 118, 153, 4, 114, 57, 4, 38, 69, 151, 151, 236, 168, 65, 8, 171, 78, 155, 197, 49, 22, 124, 242, 209, 235, 58, 247, 35, 255, 50, 197, 166, 89, 214, 131, 117, 189, 48, 206, 159, 209, 220, 99, 110, 212, 215, 210, 225, 183, 35, 226, 102, 46]))). Retrying...after display trait: 2025-12-03T23:56:47.689861Z ERROR translator_sv2::sv2::upstream::upstream: Failed Noise handshake with 188.40.233.17:34254: Invalid Certificate: SignatureNoiseMessage { version: 0, valid_from: 1764806224, not_valid_after: 1764809824, signature: 679a439dedcd34e2524a0812237575f3734fb69ccdf8b03c3019d286b63fd7c72acbbab2df28ff8541a06ad0b850e37bc0f282621ff0255a3e1b33212542f600 }. Retrying... |
GitGab19
reviewed
Dec 4, 2025
Member
|
Also, let's bump the PATCH for In this way we're gonna publish this change in the next release. |
lucasbalieiro
force-pushed
the
add-time-tolerance-to-noise-validation
branch
2 times, most recently
from
c839fcf to
00018ba
Compare
lucasbalieiro
commented
Dec 4, 2025
GitGab19
approved these changes
Dec 4, 2025
plebhash
reviewed
Dec 5, 2025
`SignatureNoiseMessage` verification now accepts messages whose `valid_from`/`not_valid_after` bounds fall within a 10-second leeway. This prevents false negatives when the local machine clock is a few seconds ahead or behind (e.g., minor NTP drift).
lucasbalieiro
force-pushed
the
add-time-tolerance-to-noise-validation
branch
from
00018ba to
33f14db
Compare
plebhash
approved these changes
Dec 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2015
SignatureNoiseMessage:: verify_with_nowverification now accepts messages whosevalid_from/not_valid_afterbounds fall within a 10-second leeway.impl Display trait for
SignatureNoiseMessage.Bump
noise-sv2from1.4.0to1.4.1