fix(translator): prevent JobIdNotFound when multiple miners connect simultaneously #224
+553
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imultaneously When multiple SV1 miners connect simultaneously in aggregated mode, the translator would fail with JobIdNotFound error when processing SetNewPrevHash messages for subsequent channels. Root cause: In handle_set_new_prev_hash, the code iterates over ALL extended channels and calls on_set_new_prev_hash() on each one. When on_set_new_prev_hash is called on a channel, it removes the job from future_jobs and clears all remaining future jobs. This causes subsequent channels to fail when they try to find the same job_id. Fix: Before calling on_set_new_prev_hash(), check if the channel actually has the referenced job in its future_jobs. Skip channels that don't have the job. Also ensure that SV1 message forwarding only happens after successful on_set_new_prev_hash() calls to prevent potential panics from get_active_job(). This fix is applied to all three code paths: 1. Aggregated mode (upstream_extended_channel and extended_channels loop) 2. Non-aggregated group channel mode 3. Non-aggregated individual channel mode
average-gary
force-pushed
the
fix/translator-job-id-not-found
branch
from
52a6f0d to
878a3ba
Compare
…gated mode This test reproduces the JobIdNotFound bug that occurs when multiple SV1 miners connect simultaneously in aggregated mode (aggregate_channels = true). The bug manifests when SetNewPrevHash arrives targeting a group channel ID: - Translator iterates over ALL extended channels in the group - First channel removes the job from future_jobs and clears remaining future jobs - Subsequent channels fail with JobIdNotFound when trying to find the same job_id Test name: aggregated_translator_handles_group_channel_set_new_prev_hash_without_job_id_not_found Test strategy: 1. Start translator in aggregated mode with MockUpstream 2. Connect 5 miners (all aggregated into same channel) 3. Send initial job (job_id=1) to establish working state 4. Send future job (job_id=2) to GROUP channel ID 5. Send SetNewPrevHash (job_id=2) to GROUP channel ID (bug trigger) 6. Verify translator survives and miners continue submitting shares Related issue: stratum-mining#223 Related PR: stratum-mining#224
Contributor
Author
|
The recently added test demonstrates the bug exists on main and is fixed by this PR: Checkout main Cherry-pick ONLY the test commit (not the fix) Run the test - it should FAIL (translator crashes with JobIdNotFound)
Now cherry-pick the fix Run the test again - it should PASS
|
average-gary
added a commit
to average-gary/sv2-apps
that referenced
this pull request
Jan 29, 2026
…gated mode This test reproduces the JobIdNotFound bug that occurs when multiple SV1 miners connect simultaneously in aggregated mode (aggregate_channels = true). The bug manifests when SetNewPrevHash arrives targeting a group channel ID: - Translator iterates over ALL extended channels in the group - First channel removes the job from future_jobs and clears remaining future jobs - Subsequent channels fail with JobIdNotFound when trying to find the same job_id Test name: aggregated_translator_handles_group_channel_set_new_prev_hash_without_job_id_not_found Test strategy: 1. Start translator in aggregated mode with MockUpstream 2. Connect 5 miners (all aggregated into same channel) 3. Send initial job (job_id=1) to establish working state 4. Send future job (job_id=2) to GROUP channel ID 5. Send SetNewPrevHash (job_id=2) to GROUP channel ID (bug trigger) 6. Verify translator survives and miners continue submitting shares Related issue: stratum-mining#223 Related PR: stratum-mining#224
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #223
Prevents
JobIdNotFounderror when multiple SV1 miners connect simultaneously in aggregated mode.Problem
When multiple miners connect at the same time, the translator would fail because
handle_set_new_prev_hashiterates over ALL extended channels and callson_set_new_prev_hash()on each one. Sinceon_set_new_prev_hash()removes the job fromfuture_jobsand clears remaining jobs, subsequent channels fail when they try to find the same job_id.Solution
Before calling
on_set_new_prev_hash(), check if the channel actually has the referenced job in itsfuture_jobs. Skip channels that don't have the job.This fix is applied to all three code paths in
handle_set_new_prev_hash:Testing
Changes
miner-apps/translator/src/lib/sv2/channel_manager/mining_message_handler.rs: Added defensive checks before callingon_set_new_prev_hash()to verify job exists infuture_jobs