replace tokio::sync::broadcast as the main shutdown notification system
#225
+1,146
−1,236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plebhash
force-pushed
the
2026-01-27-cancellation-tokens
branch
5 times, most recently
from
20987ec to
39e49a9
Compare
plebhash
commented
Jan 30, 2026
| } | ||
| _ = fallback_token.cancelled() => { | ||
| info!("Channel Manager: fallback triggered, resetting state"); | ||
| self.upstream_state.set(UpstreamState::SoloMining); |
Member
Author
There was a problem hiding this comment.
I vaguely remember reading debates on whether this is the right thing to do or not
I haven't fully analyzed that discussion in depth, so I have no stance on it
this PR aims to be orthogonal to that discussion, so we're simply preserving the same behavior that existed before
…cted_txids_in_provide_missing_transaction_success
plebhash
force-pushed
the
2026-01-27-cancellation-tokens
branch
from
39e49a9 to
53e33be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #215
in this PR we:
ShutdownMessage+notify_shutdown: tokio::sync::broadcast(and all the corresponding machinery) from all appsCancellationTokento all appsstratum-apps::fallback_coordinator::FallbackCoordinatorto tProxy + JDCsome relevant notes:
FallbackCoordinatorChannelManager,Sv1Server,MonitoringServer), and instead, we re-initialize all of them... the component initialization routines are currently duplicated for clarity, but happy to modularize them into a single functiona few days ago I framed this as something to be done under the scope of #24
along the way I realized it was better to shape this as a standalone thing, which hopefully can serve as foundation for #24 once merged (together with lots of foundations already established via #132)