fix: consolidate multi-row markdown table cells in Mining Protocol#186
Open
average-gary wants to merge 1 commit intostratum-mining:mainfrom
Open
fix: consolidate multi-row markdown table cells in Mining Protocol#186average-gary wants to merge 1 commit intostratum-mining:mainfrom
average-gary wants to merge 1 commit intostratum-mining:mainfrom
Conversation
Multi-line table descriptions in standard markdown render as separate rows with empty cells rather than a single cell with wrapped text. This affects the SetupConnection flags tables and the SetCustomMiningJob.Success table in the Mining Protocol spec.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
05-Mining-Protocol.mdused continuation rows (rows with empty Flag Name / Bit cells) to wrap long descriptions across multiple lines. Standard markdown renderers treat each|...|line as its own row, so these render as broken tables with orphaned empty cells.SetupConnection.flags,SetupConnection.Success.flags, andSetCustomMiningJob.Successtables.These tables did not render well on the site.
Before
SetupConnection.Success.flags table
SetCustomMiningJob.Success table