Update table class to reflect upstream, and Grafana V8+#17
Open
pauloconnor wants to merge 1 commit intomainfrom
Open
Update table class to reflect upstream, and Grafana V8+#17pauloconnor wants to merge 1 commit intomainfrom
pauloconnor wants to merge 1 commit intomainfrom
Conversation
pauloconnor
force-pushed
the
poconnor/table
branch
from
fcaad17 to
b13a300
Compare
sabriel27
approved these changes
May 17, 2024
Author
|
I'm not sure if this is worth doing at this point. We could in theory move to the upstream version of the library, but weaveworks closed down a while back, so grafanalib is abandonware now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I was updating from upstream the last time, we had to keep the
Tableclass as the old version, since Grafana changed it in V8, and we were running V6. V10+ now doesn't understand the old version, so we need to swap them out.Also fix the merge conflict we had previously.