Open
Conversation
|
@tyvich - we have started building off of our own forked edition of grafanalib. We are not, at this time at least, officially supporting it but are happy to merge this PR (we ported from upstream) and further ones if you need. No warranty implied, caveat emptor but it might be helpful to you to have this merged somewhere upstream? |
Author
|
@daveworth Makes Sense, thanks for the Feedback I'll put in a PR on the original repo as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
Created three new attributes on Template class to support an interval Template Type
Why is it a good idea?
Allows use of grafanalib to provision dashboards with these template types
Context
Original repo looks dead, so submitting to this one due to the active pull requests.
https://github.com/grafana/grafana/blob/v6.0.x/docs/sources/reference/dashboard.md
The docs don't have anything about these fields in the JSON Model; however, it appears they are necessary/generated when creating this variable type via the UI.
Questions
Please let me know if I should fix anything, thanks