Skip to content

Commit 88e5b8e

Browse files
committed
Set nullable at the beginning
1 parent a79831e commit 88e5b8e

File tree

3 files changed

+17
-90
lines changed

3 files changed

+17
-90
lines changed

fastapi-sqlalchemy/alembic/versions/3a98bc1018d1_add_nullable_false.py

Lines changed: 0 additions & 74 deletions
This file was deleted.

fastapi-sqlalchemy/alembic/versions/d117aba82184_add_initial_models.py renamed to fastapi-sqlalchemy/alembic/versions/9bc8667ab6a6_add_initial_models.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
"""Add initial models
22
3-
Revision ID: d117aba82184
3+
Revision ID: 9bc8667ab6a6
44
Revises:
5-
Create Date: 2021-09-09 21:15:39.715853
5+
Create Date: 2021-09-10 16:00:02.842263
66
77
"""
88
from alembic import op
99
import sqlalchemy as sa
1010

1111

1212
# revision identifiers, used by Alembic.
13-
revision = "d117aba82184"
13+
revision = "9bc8667ab6a6"
1414
down_revision = None
1515
branch_labels = None
1616
depends_on = None
@@ -21,21 +21,21 @@ def upgrade():
2121
op.create_table(
2222
"directors",
2323
sa.Column("id", sa.Integer(), nullable=False),
24-
sa.Column("name", sa.String(), nullable=True),
24+
sa.Column("name", sa.String(), nullable=False),
2525
sa.PrimaryKeyConstraint("id"),
2626
)
2727
op.create_index(op.f("ix_directors_id"), "directors", ["id"], unique=False)
2828
op.create_index(op.f("ix_directors_name"), "directors", ["name"], unique=True)
2929
op.create_table(
3030
"movies",
3131
sa.Column("id", sa.Integer(), nullable=False),
32-
sa.Column("title", sa.String(), nullable=True),
33-
sa.Column("imdb_id", sa.String(), nullable=True),
34-
sa.Column("year", sa.Integer(), nullable=True),
35-
sa.Column("image_url", sa.String(), nullable=True),
36-
sa.Column("imdb_rating", sa.Float(), nullable=True),
37-
sa.Column("imdb_rating_count", sa.String(), nullable=True),
38-
sa.Column("director_id", sa.Integer(), nullable=True),
32+
sa.Column("title", sa.String(), nullable=False),
33+
sa.Column("imdb_id", sa.String(), nullable=False),
34+
sa.Column("year", sa.Integer(), nullable=False),
35+
sa.Column("image_url", sa.String(), nullable=False),
36+
sa.Column("imdb_rating", sa.Float(), nullable=False),
37+
sa.Column("imdb_rating_count", sa.String(), nullable=False),
38+
sa.Column("director_id", sa.Integer(), nullable=False),
3939
sa.ForeignKeyConstraint(
4040
["director_id"],
4141
["directors.id"],

fastapi-sqlalchemy/alembic/versions/3320c3c008d2_add_data.py renamed to fastapi-sqlalchemy/alembic/versions/bea5e58f3328_add_data.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
"""Add data
22
3-
Revision ID: 3320c3c008d2
4-
Revises: d117aba82184
5-
Create Date: 2021-09-09 21:16:08.831902
3+
Revision ID: bea5e58f3328
4+
Revises: 9bc8667ab6a6
5+
Create Date: 2021-09-10 16:00:20.280277
66
77
"""
88
import json
@@ -15,11 +15,12 @@
1515

1616

1717
# revision identifiers, used by Alembic.
18-
revision = "3320c3c008d2"
19-
down_revision = "d117aba82184"
18+
revision = "bea5e58f3328"
19+
down_revision = "9bc8667ab6a6"
2020
branch_labels = None
2121
depends_on = None
2222

23+
2324
current_dir = Path(__file__).parent.resolve()
2425
data_file = current_dir.parent.parent.parent / Path("common-data") / Path("movies.json")
2526

0 commit comments

Comments
 (0)