-
-
Notifications
You must be signed in to change notification settings - Fork 144
[Draft] add: tools for creating combined permissions #749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
iamcrookedman
wants to merge
4
commits into
strawberry-graphql:main
Choose a base branch
from
iamcrookedman:feature/combined-permissions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[Draft] add: tools for creating combined permissions #749
iamcrookedman
wants to merge
4
commits into
strawberry-graphql:main
from
iamcrookedman:feature/combined-permissions
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's GuideImplements a composable permission framework with logical operators (AND, OR, NOT) and adds a GraphQL extension to apply multiple permission classes per field. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
for more information, see https://pre-commit.ci
3 tasks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @iamcrookedman - I've reviewed your changes - here's some feedback:
- Consider normalizing operand order in OperandHolder for commutative operators like AND/OR so that A & B and B & A produce equivalent holders.
- Add eq and hash implementations to SingleOperandHolder to match OperandHolder and ensure permission expressions can be reliably compared and used as dict keys.
- Add type hints or runtime validation in HasPermissionClasses to ensure that permission_classes is an iterable of BasePermission subclasses to catch misconfigurations early.
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
…to feature/combined-permissions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist
Summary by Sourcery
Add support for composing permissions with boolean operators and enforce multiple permission classes in GraphQL extensions
New Features: