This repository was archived by the owner on Jan 25, 2026. It is now read-only.
Conversation
…add lint/check/type-check to PR checks
There was a problem hiding this comment.
Pull Request Overview
This PR refactors existing agents into a centralized library structure while adding lint, check, and type-check validation to PR workflows. The main purpose is to consolidate agent implementations under a unified library package and establish consistent code quality checks.
Key changes:
- Consolidates individual agent packages into a single
fastmcp-agents-library-agentspackage - Removes standalone agent packages for filesystem, elasticsearch, and documentation maintainer
- Adds ruff format/check and type checking to CI pipeline
Reviewed Changes
Copilot reviewed 46 out of 54 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
fastmcp-agents-library/agents/fastmcp-agents-library-agents/ |
New consolidated agents package with filesystem, elasticsearch, simple_code, and github agents |
fastmcp-agents-library/agents/fastmcp-agents-library-agent-* |
Removed standalone agent packages |
fastmcp-agents-cli/tests/test_cli.py |
Updated tests to use temporary directories instead of hardcoded paths |
.github/workflows/on-pr.yml |
Added ruff format, ruff check, and basedpyright type checking steps |
Comments suppressed due to low confidence (3)
fastmcp-agents-library/agents/fastmcp-agents-library-agents/pyproject.toml
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also add lint/check/type-check to PR checks