haiku: improve C++ glue #159
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@Kijewski would you be able to run the example in your haiku env? |
lopopolo
force-pushed
the
dev/lopopolo-haiku-null-buf
branch
from
44148a3 to
185a25d
Compare
- Defend against NULL input buffer. - Use auto and static_cast to clean up type conversions. - Use BString::CopyInto API instead of raw memcpy. - NUL terminate the buffer if possible.
```sh clang-tidy '--checks=*,-llvmlibc-restrict-system-libc-headers,-fuchsia-trailing-return' haiku/src/implementation.cc ```
lopopolo
force-pushed
the
dev/lopopolo-haiku-null-buf
branch
from
4da4bca to
f9b3292
Compare
- extern C decl. - [[nodiscard]] and [[maybe_unused]] attributes - always null-terminate - catch std::exception explicitly - mark C ABI function as noexcept - compare locale with nullptr - avoid overflowing addition - add doxygen doc comments (thanks ChatGPT)
Collaborator
Author
|
This PR will address https://github.com/strawlab/iana-time-zone/security/code-scanning/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've bumped the crate version to prep for a release. Should also include #154 before it gets cut.
I've also run this through clang-tidy and modernized things a bit.