Conversation
|
Alpha versions of packages are published 📦 PR: #335 |
dperdic-streamflow
left a comment
dperdic-streamflow
left a comment
There was a problem hiding this comment.
Lgtm, just fix the comment
| }; | ||
| } | ||
|
|
||
| async prepareCreateFundDelegateInstructions( |
There was a problem hiding this comment.
since it's publicly accessible add an explicit return type
There was a problem hiding this comment.
one more thing, some checks would be nice here since the protocol has these
startTs must not be in the past
period must be >= 1 day and <= expiry duration
expiryTs must be after startTs
There was a problem hiding this comment.
But all these checks are done on the protocol side. And we have some error extraction.
There was a problem hiding this comment.
I was thinking to make it more dev friendly since this is public so we don't get unnecessary questions
There was a problem hiding this comment.
And with typing the prepare it would probably require a full refactoring - we never typed prepare... method. 🌚
I've added the interface, only for this method now tho.
2 participants
createFundDelegate- allows periodical automated top ups for reward pools with Dynamic APY;