fix: write the last cursor on terminating regardless of err is nil or not#6
Open
fish-sammy wants to merge 1 commit intostreamingfast:developfrom
Open
fix: write the last cursor on terminating regardless of err is nil or not#6fish-sammy wants to merge 1 commit intostreamingfast:developfrom
fish-sammy wants to merge 1 commit intostreamingfast:developfrom
Conversation
fish-sammy
force-pushed
the
fix/write-last-cursor
branch
from
405edeb to
d33233c
Compare
maoueh
reviewed
Nov 24, 2025
Comment on lines
+57
to
+58
| func (s *MongoSinker) writeLastCursor(ctx context.Context, _ error) { | ||
| if s.lastCursor == nil { |
Contributor
There was a problem hiding this comment.
This is problematic to my eyes, what if the error make it such that the block wasn't fully written and then the cursor is saved? This would mean a block half-written and a cursor saved.
Contributor
Author
There was a problem hiding this comment.
How can that happen with how HandleBlockScopedData is currently written?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.