settings: enable "rescale output" dropdown on Windows/macOS #1619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleksandr-voitenko
approved these changes
Jan 15, 2026
mhoyer-streamlabs
approved these changes
Jan 15, 2026
Contributor
mhoyer-streamlabs
left a comment
mhoyer-streamlabs
left a comment
There was a problem hiding this comment.
Approving but curious about Mac always being visible but only for a certain encoder on Windows, why is that?
Contributor
Author
Honestly, I think the logic is inverted the more I think about it? git blame says it got changed here. Maybe what we want here is this? Will be cleaner fix. This bug was only reported on Apple mac during the full run which was reason I went with prev fix. But open to change it to this if @aleksandr-voitenko concurs? [edit] This issue was discussed in slack. Went with this solution and updated PR |
* I think this logic was inverted? Updating to allow all encoders thru EXCEPT the deprecated one
sandboxcoder
force-pushed
the
rno/mac-rescaleoutput
branch
from
a3f1095 to
bf1beea
Compare
sandboxcoder
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable "Rescale Output" dropdown on MacOS. Related PR where I enabled the checkbox but now we're revealing the dropdown as well.
Motivation and Context
Restoring legacy feature from 1.19.6 where you could rescale output
How Has This Been Tested?
Types of changes
Checklist: