CI: Drop the dead Sentry and breakpad downloads - #1748
Merged
Conversation
prepare-artifact.cmd fetches breakpad-tools and sentry-cli 1.48.0 into the workspace root on every tag build, but the artifact step only uploads streamlabs-build.app/ and tests/osn-tests/osn/index.ts, so both are discarded. Nothing else in the job uses them. It dates to #540 (Nov 2019), before Windows symbols moved to the AWS symbol store and Sentry was pointed at that instead. copy-files.cmd is from the same era and is entirely commented out, yet still runs as a step every build. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…y-breakpad-downloads
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes two legacy Windows CI helper scripts (ci/prepare-artifact.cmd, ci/copy-files.cmd) and deletes the corresponding workflow steps that invoked them, since their outputs were not referenced by later steps nor included in uploaded artifacts.
Changes:
- Delete
ci/prepare-artifact.cmd(breakpad-tools + sentry-cli download for tag builds). - Delete
ci/copy-files.cmd(fully commented-out DLL copy helper). - Remove both steps from the Windows build job in
.github/workflows/main.yml.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
ci/prepare-artifact.cmd |
Removed unused script that downloaded breakpad-tools and sentry-cli.exe but whose outputs were not consumed or uploaded. |
ci/copy-files.cmd |
Removed unused script containing only commented-out copy commands. |
.github/workflows/main.yml |
Removed the two Windows CI steps that invoked the deleted scripts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
summeroff
added a commit
to streamlabs/desktop
that referenced
this pull request
Jul 28, 2026
Bumps obs-studio-node 0.26.29b18 -> 0.27.2. Supersedes #6037, which covered 0.27.0/0.27.1 and is folded into this change so the whole bump lands as one commit. osn changes in 0.27.0 / 0.27.1: * OBS Merge 32.1.1 (streamlabs/obs-studio-node#1722) - Aleksandr Voitenko * Add signals for missing resolutions in Enhanced Boradcasting (streamlabs/obs-studio-node#1742) - Aleksandr Voitenko * Add enhanced broadcasting per-display stats (streamlabs/obs-studio-node#1738) - Aleksandr Voitenko * Fix recording custom track names (streamlabs/obs-studio-node#1741) - Aleksandr Voitenko * Expose structured module load failures (streamlabs/obs-studio-node#1733) - Aleksandr Voitenko * Fix misleading [BrowserMessage] log tag on generic source ops (streamlabs/obs-studio-node#1725) - Vladimir * osn-input: log source id before creating input (streamlabs/obs-studio-node#1721) - Vladimir osn changes in 0.27.2: * tests: regression for scene-wrapped source audio (#1493) (streamlabs/obs-studio-node#1724) - Vladimir * Fix startup crash when recording audio encoder is not registered (streamlabs/obs-studio-node#1736) - Vladimir * CI: Pin symsrv-scripts to v1.1.1 (streamlabs/obs-studio-node#1752) - Vladimir * Update libobs to v32.1.1sl2 (streamlabs/obs-studio-node#1751) - Vladimir * CI: Drop the dead Sentry and breakpad downloads (streamlabs/obs-studio-node#1748) - Vladimir
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove
ci/prepare-artifact.cmdandci/copy-files.cmdand the two steps that invoke them from the Windows build.Motivation and Context
prepare-artifact.cmddownloads breakpad-tools and sentry-cli 1.48.0 into the workspace root on every tag build. The artifact step only uploadsstreamlabs-build.app/andtests/osn-tests/osn/index.ts, so both land outside it and are discarded, and nothing else in the job references them.It comes from #540 (Nov 2019), before Windows symbols moved to the AWS symbol store with Sentry pointed at that instead.
copy-files.cmdis from the same era — it is entirely commented out and still runs as a step on every build.Found while looking at why the obs-studio symbol upload had grown so expensive.
How Has This Been Tested?
Not run in CI. Static verification only:
git grepover the repo (excludingnode_modules) finds no remaining reference to either script, or tobreakpad/sentry-cli.exeactionlintonmain.yml: 4 findings before, 4 after, all pre-existingmacos-15-intellabel warningsci/sentry-osx.pyis untouched and still wired into the macOS jobThe macOS Sentry path is unaffected. Worth a look from whoever remembers #540, in case those binaries were meant to be picked up by something downstream that has since moved.
Types of changes
Checklist: