fix: validate recording output paths by summeroff · Pull Request #1755 · streamlabs/obs-studio-node

summeroff · 2026-08-06T01:25:49Z

Summary

companion to obs-studio): reject unsafe recording/replay directories at start via os_is_path_safe.

Covers simple/advanced recording and both replay buffers.

Test plan

Start recording/replay with normal path
Start with symlink/junction directory path → rejected

Copilot

Pull request overview

This PR tightens recording/replay-buffer startup validation by rejecting unsafe output directories (e.g., symlink/junction paths) using os_is_path_safe, aligning behavior with upstream OBS safety expectations.

Changes:

Add os_is_path_safe validation for simple recording output directory before starting recording.
Add os_is_path_safe validation for simple and advanced replay buffer output directory before starting replay buffer.
Add os_is_path_safe validation for advanced recording output directory before building the final output file path.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File	Description
obs-studio-server/source/osn-simple-replay-buffer.cpp	Rejects unsafe/empty replay buffer directory before output update/start.
obs-studio-server/source/osn-simple-recording.cpp	Rejects unsafe/empty recording directory before constructing the final recording file path.
obs-studio-server/source/osn-advanced-replay-buffer.cpp	Rejects unsafe/empty replay buffer directory before output update/start.
obs-studio-server/source/osn-advanced-recording.cpp	Rejects unsafe/empty recording directory before constructing the final recording file path.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

summeroff · 2026-08-09T22:33:00Z


-	if (!recording->path.size()) {
+	if (!recording->path.size() || !os_is_path_safe(recording->path.c_str())) {
 		PRETTY_ERROR_RETURN(ErrorCode::InvalidReference, "Invalid recording path.");


Done. Rather than reword the shared message, the check is now split so each branch says what actually tripped:

if (!recording->path.size()) { PRETTY_ERROR_RETURN(ErrorCode::InvalidReference, "Invalid recording path."); } if (!os_is_path_safe(recording->path.c_str())) { PRETTY_ERROR_RETURN(ErrorCode::InvalidReference, "Unsafe recording path: symbolic links and junctions are not allowed."); }

PRETTY_ERROR_RETURN puts the string in both the IPC return value and the log, so this reaches the desktop error and the support log. Applied consistently across all four files.

summeroff · 2026-08-09T22:33:01Z


 	obs_output_set_video_encoder(recording->GetOutput(), recording->videoEncoder);
+	if (!recording->path.size() || !os_is_path_safe(recording->path.c_str())) {
+		PRETTY_ERROR_RETURN(ErrorCode::InvalidReference, "Invalid recording path.");


Done. Rather than reword the shared message, the check is now split so each branch says what actually tripped:

if (!recording->path.size()) { PRETTY_ERROR_RETURN(ErrorCode::InvalidReference, "Invalid recording path."); } if (!os_is_path_safe(recording->path.c_str())) { PRETTY_ERROR_RETURN(ErrorCode::InvalidReference, "Unsafe recording path: symbolic links and junctions are not allowed."); }

PRETTY_ERROR_RETURN puts the string in both the IPC return value and the log, so this reaches the desktop error and the support log. Applied consistently across all four files.

summeroff · 2026-08-09T22:33:03Z


-	if (!replayBuffer->path.size()) {
+	if (!replayBuffer->path.size() || !os_is_path_safe(replayBuffer->path.c_str())) {
 		PRETTY_ERROR_RETURN(ErrorCode::InvalidReference, "Invalid recording path.");


Done. Rather than reword the shared message, the check is now split so each branch says what actually tripped:

if (!recording->path.size()) { PRETTY_ERROR_RETURN(ErrorCode::InvalidReference, "Invalid recording path."); } if (!os_is_path_safe(recording->path.c_str())) { PRETTY_ERROR_RETURN(ErrorCode::InvalidReference, "Unsafe recording path: symbolic links and junctions are not allowed."); }

PRETTY_ERROR_RETURN puts the string in both the IPC return value and the log, so this reaches the desktop error and the support log. Applied consistently across all four files.

summeroff · 2026-08-09T22:33:04Z


-	if (!replayBuffer->path.size()) {
+	if (!replayBuffer->path.size() || !os_is_path_safe(replayBuffer->path.c_str())) {
 		PRETTY_ERROR_RETURN(ErrorCode::InvalidReference, "Invalid recording path.");


Done. Rather than reword the shared message, the check is now split so each branch says what actually tripped:

if (!recording->path.size()) { PRETTY_ERROR_RETURN(ErrorCode::InvalidReference, "Invalid recording path."); } if (!os_is_path_safe(recording->path.c_str())) { PRETTY_ERROR_RETURN(ErrorCode::InvalidReference, "Unsafe recording path: symbolic links and junctions are not allowed."); }

PRETTY_ERROR_RETURN puts the string in both the IPC return value and the log, so this reaches the desktop error and the support log. Applied consistently across all four files.

Splitting the empty-path and os_is_path_safe() checks lets the IPC error and the log line say which one tripped, so a rejected symlink/junction directory is diagnosable instead of just "Invalid recording path." Also switch osn-encoders.hpp to a quoted include, matching every other consumer of that header. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Suppressed comments (8)

obs-studio-server/source/osn-simple-recording.cpp:406

os_is_path_safe also returns false when a path component is missing, inaccessible, malformed, or not a directory, so this message can incorrectly blame a symbolic link/junction for ordinary path failures. Make the message cover those failure modes as well.

		PRETTY_ERROR_RETURN(ErrorCode::InvalidReference, "Unsafe recording path: symbolic links and junctions are not allowed.");

obs-studio-server/source/osn-advanced-recording.cpp:291

os_is_path_safe also returns false when a path component is missing, inaccessible, malformed, or not a directory, so this message can incorrectly blame a symbolic link/junction for ordinary path failures. Make the message cover those failure modes as well.

		PRETTY_ERROR_RETURN(ErrorCode::InvalidReference, "Unsafe recording path: symbolic links and junctions are not allowed.");

obs-studio-server/source/osn-simple-replay-buffer.cpp:152

os_is_path_safe also returns false when a path component is missing, inaccessible, malformed, or not a directory, so this message can incorrectly blame a symbolic link/junction for ordinary path failures. Make the message cover those failure modes as well.

		PRETTY_ERROR_RETURN(ErrorCode::InvalidReference, "Unsafe recording path: symbolic links and junctions are not allowed.");

obs-studio-server/source/osn-advanced-replay-buffer.cpp:210

os_is_path_safe also returns false when a path component is missing, inaccessible, malformed, or not a directory, so this message can incorrectly blame a symbolic link/junction for ordinary path failures. Make the message cover those failure modes as well.

		PRETTY_ERROR_RETURN(ErrorCode::InvalidReference, "Unsafe recording path: symbolic links and junctions are not allowed.");

obs-studio-server/source/osn-simple-recording.cpp:406

The simple-recording integration suite exercises start() with normal paths, but no automated case verifies that this new branch rejects a Windows symlink/junction path and propagates the intended error. Add a regression case so this security boundary cannot silently disappear.

This issue also appears on line 406 of the same file.

	if (!os_is_path_safe(recording->path.c_str())) {
		PRETTY_ERROR_RETURN(ErrorCode::InvalidReference, "Unsafe recording path: symbolic links and junctions are not allowed.");

obs-studio-server/source/osn-advanced-recording.cpp:291

The advanced-recording integration suite exercises start() with normal paths, but no automated case verifies that this new branch rejects a Windows symlink/junction path and propagates the intended error. Add a regression case so this security boundary cannot silently disappear.

This issue also appears on line 291 of the same file.

	if (!os_is_path_safe(recording->path.c_str())) {
		PRETTY_ERROR_RETURN(ErrorCode::InvalidReference, "Unsafe recording path: symbolic links and junctions are not allowed.");

obs-studio-server/source/osn-simple-replay-buffer.cpp:152

The simple replay-buffer integration suite exercises start() with normal paths, but no automated case verifies that this new branch rejects a Windows symlink/junction path and propagates the intended error. Add a regression case so this security boundary cannot silently disappear.

This issue also appears on line 152 of the same file.

	if (!os_is_path_safe(replayBuffer->path.c_str())) {
		PRETTY_ERROR_RETURN(ErrorCode::InvalidReference, "Unsafe recording path: symbolic links and junctions are not allowed.");

obs-studio-server/source/osn-advanced-replay-buffer.cpp:210

The advanced replay-buffer integration suite exercises start() with normal paths, but no automated case verifies that this new branch rejects a Windows symlink/junction path and propagates the intended error. Add a regression case so this security boundary cannot silently disappear.

This issue also appears on line 210 of the same file.

	if (!os_is_path_safe(replayBuffer->path.c_str())) {
		PRETTY_ERROR_RETURN(ErrorCode::InvalidReference, "Unsafe recording path: symbolic links and junctions are not allowed.");

summeroff changed the title ~~fix: H1-3335237 validate recording output paths~~ fix: validate recording output paths Aug 6, 2026

summeroff requested a lite review from Copilot August 6, 2026 01:28

Copilot started reviewing on behalf of summeroff August 6, 2026 01:28 View session

Copilot AI reviewed Aug 6, 2026

View reviewed changes

summeroff and others added 2 commits August 9, 2026 23:50

Validate recording output directories

3bdd761

summeroff force-pushed the fix/h1-3335237-safe-recording branch from 014dd0f to 0387e73 Compare August 9, 2026 21:55

summeroff requested a balanced review from Copilot August 9, 2026 22:36

Copilot started reviewing on behalf of summeroff August 9, 2026 22:37 View session

Copilot AI reviewed Aug 9, 2026

View reviewed changes

summeroff merged commit 19278f8 into staging Aug 9, 2026
21 checks passed

Navigation Menu

Uh oh!

fix: validate recording output paths - #1755

fix: validate recording output paths#1755
summeroff merged 2 commits into
stagingfrom
fix/h1-3335237-safe-recording

summeroff commented Aug 6, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

summeroff Aug 9, 2026

Uh oh!

summeroff Aug 9, 2026

Uh oh!

summeroff Aug 9, 2026

Uh oh!

summeroff Aug 9, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

summeroff commented Aug 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

summeroff Aug 9, 2026

Choose a reason for hiding this comment

Uh oh!

summeroff Aug 9, 2026

Choose a reason for hiding this comment

Uh oh!

summeroff Aug 9, 2026

Choose a reason for hiding this comment

Uh oh!

summeroff Aug 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

summeroff commented Aug 6, 2026 •

edited

Loading