Skip to content

Conversation

@sandboxcoder
Copy link

@sandboxcoder sandboxcoder commented Dec 5, 2025

Description

  • revert d85f89a (change I made). Apparently com.apple.audio.IOThread.client (audio thread) is already elevated so this change isn't going to assist users on macOS 26 experiencing choppy audio so its best to remove this code to avoid future merge conflicts when we pull
  • This is the reconnect_thread which is only invoked when missing a device (coreaudio is trying to reconnect the device)

Motivation and Context

Misunderstood coreaudio, removing non-beneficial code

How Has This Been Tested?

Tested this change with Desktop.

Types of changes

  • Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the streamlabs branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

* revert d85f89a (change I made).
Apple docs say com.apple.audio.IOThread.client is already elevated so this
change isn't going to assist users on macOS 26 experiencing choppy audio
so its best to remove this code
@sandboxcoder sandboxcoder marked this pull request as ready for review December 5, 2025 16:41
@sandboxcoder sandboxcoder changed the title revert thread priority revert mac coreaudio thread priority Dec 5, 2025
@sandboxcoder sandboxcoder merged commit 417ec1b into streamlabs Dec 5, 2025
14 checks passed
@sandboxcoder sandboxcoder deleted the rno/mac-audio branch December 5, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants