Fixed enhanced broadcasting encoders when using on high end GPU #694
+88
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed enhanced broadcasting encoding silent failure when using it on high-end GPU with high resolutions.
From the user perspective it looks like they go live, but there is no stream.
Motivation and Context
The issue was reproduced for discrete GPUs like
NVIDIA GeForce RTX 4070 Ti SUPERand resolutions like2560x1440and1080x1920in dual streaming mode. In this case Twitch asks 8 streams to encode. The root cause is inside OBS's encoder groups and how they handle a case when the number of created encoders is larger than the maximum supported amount. Fortunately, the fix/workaround is straightforward; I back-ported the value of the constantMAX_OUTPUT_VIDEO_ENCODERSand made other appropriate changes to reuse video mixes.How Has This Been Tested?
Manually, Windows
Types of changes