obs-nvenc: destroy NVENC resources before session cleanup#702
Open
aleksandr-voitenko wants to merge 1 commit intostreamlabsfrom
Open
obs-nvenc: destroy NVENC resources before session cleanup#702aleksandr-voitenko wants to merge 1 commit intostreamlabsfrom
aleksandr-voitenko wants to merge 1 commit intostreamlabsfrom
Conversation
sandboxcoder
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes NVENC teardown ordering and adds checks to prevent NVENC API calls with an invalid/destroyed session handle.
Problem
At the moment, destroy sequence calls
nvEncDestroyEncoderbefore releasing all NVENC-created input resources (registered textures/surfaces).That violates the NVENC API contract and can lead to invalid session usage during cleanup.
See for details in
nvenc.cfunctionnvenc_destroy().Inside
d3d11_free_textures:Inside
cuda_free_surfaces:How Has This Been Tested?
Manually, Windows only.
Types of changes