Skip to content

Conversation

@sfc-gh-bnisco
Copy link
Contributor

@sfc-gh-bnisco sfc-gh-bnisco commented Oct 28, 2025

TL;DR

Restructured the component templates directory to support versioning and improved build process compatibility.

What changed?

  • Moved template directories into a versioned structure (templates/v1/template and templates/v1/template-reactless)
  • Added support for future template versions with a v2 directory
  • Updated the example directory discovery to handle the new versioned structure
  • Added support for projects using pyproject.toml in the build process
  • Implemented a robust directory comparison function that respects .gitignore rules, fixing an issue when running these commands locally
  • Enhanced the template checking process to properly handle git-ignored files

Why make this change?

This change prepares the codebase for supporting multiple versions of component templates, allowing for backward compatibility while introducing new features. The improved build process compatibility ensures modern Python packaging approaches (pyproject.toml) are supported alongside traditional setup.py. The enhanced directory comparison makes template verification more reliable by properly handling git-ignored files.

@sfc-gh-bnisco sfc-gh-bnisco force-pushed the v2-support-move-templates branch from 628810e to c7b496d Compare October 31, 2025 18:26
@sfc-gh-bnisco sfc-gh-bnisco marked this pull request as ready for review October 31, 2025 18:27
@sfc-gh-bnisco sfc-gh-bnisco requested review from a team as code owners October 31, 2025 18:27
@sfc-gh-bnisco sfc-gh-bnisco changed the base branch from v2-support-scaffold to graphite-base/110 October 31, 2025 18:33
@sfc-gh-bnisco sfc-gh-bnisco force-pushed the v2-support-move-templates branch from c7b496d to 4bee68c Compare October 31, 2025 18:33
@sfc-gh-bnisco sfc-gh-bnisco changed the base branch from graphite-base/110 to master October 31, 2025 18:36
@sfc-gh-bnisco sfc-gh-bnisco merged commit 27b3742 into master Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants