Skip to content

Conversation

@yaalsn
Copy link
Contributor

@yaalsn yaalsn commented Nov 20, 2024

Motivation

https://github.com/streamnative/snip/pull/82

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@github-actions github-actions bot added the no-need-doc This pr does not need any document label Nov 20, 2024
@yaalsn yaalsn changed the title Support sn bom [WIP]Support sn bom Nov 20, 2024
@yaalsn yaalsn changed the title [WIP]Support sn bom [WIP]Support SN bom Nov 20, 2024
@yaalsn yaalsn changed the title [WIP]Support SN bom Use SN bom Jan 13, 2025
@gaoran10 gaoran10 merged commit b81f1b5 into master Jan 14, 2025
2 checks passed
@gaoran10 gaoran10 deleted the sn-bom branch January 14, 2025 07:08
gaoran10 pushed a commit that referenced this pull request Jan 14, 2025
* Support sn bom

* Add github maven package

* Add test related dependencies

* Add jar instead of nar package to image

(cherry picked from commit b81f1b5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants