Revert to using the nar package #1634
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR reverts to using the NAR package format and adds necessary Qpid dependencies. The change switches from JAR to NAR packaging in the build process while adding Apache Qpid dependencies for AMQP protocol handling.
- Switch build output from JAR to NAR format for the protocol handler
- Add Apache Qpid broker dependencies with exclusions to avoid conflicts
- Enhance error handling in ProxyConnection by replacing specific exception with generic Exception
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| scripts/build.sh | Changes Maven output from JAR to NAR format |
| pom.xml | Adds Qpid broker dependencies with exclusions |
| amqp-impl/src/main/java/io/streamnative/pulsar/handlers/amqp/proxy/ProxyConnection.java | Updates exception handling and adds error logging |
amqp-impl/src/main/java/io/streamnative/pulsar/handlers/amqp/proxy/ProxyConnection.java
Show resolved
Hide resolved
amqp-impl/src/main/java/io/streamnative/pulsar/handlers/amqp/proxy/ProxyConnection.java
Outdated
Show resolved
Hide resolved
yaalsn
approved these changes
Aug 4, 2025
gaoran10
force-pushed
the
add-qpid-dependencies
branch
from
e16a9d8 to
72875f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Revert to using the nar package.
Modifications
Add qpid dependencies for the module
amqp-impl.Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)