Skip to content

Upgrade to 4.2.0-SNAPSHOT and use commons-lang3 #1684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yaalsn merged 2 commits into from
Oct 10, 2025
Merged

Upgrade to 4.2.0-SNAPSHOT and use commons-lang3 #1684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8684cd3
Upgrade to 4.2.0-SNAPSHOT and use commons-lang3
yaalsn Oct 10, 2025
c55259c
change to use commons3 StringUtils
gaoran10 Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion amqp-impl/src/main/java/io/streamnative/pulsar/handlers/amqp/AmqpConnection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
import lombok.Getter;
import lombok.extern.log4j.Log4j2;
import org.apache.bookkeeper.util.collections.ConcurrentLongLongHashMap;
import org.apache.commons.lang.StringUtils;
import org.apache.commons.lang3.StringUtils;
import org.apache.pulsar.broker.authentication.AuthenticationProvider;
import org.apache.pulsar.broker.authentication.AuthenticationState;
import org.apache.pulsar.broker.namespace.LookupOptions;
Expand Down
2 changes: 1 addition & 1 deletion amqp-impl/src/main/java/io/streamnative/pulsar/handlers/amqp/proxy/ProxyConnection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ public void receiveConnectionOpen(AMQShortString virtualHost, AMQShortString cap
String virtualHostStr = AMQShortString.toString(virtualHost);
if ((virtualHostStr != null) && virtualHostStr.charAt(0) == '/') {
virtualHostStr = virtualHostStr.substring(1);
if (org.apache.commons.lang.StringUtils.isEmpty(virtualHostStr)){
if (StringUtils.isEmpty(virtualHostStr)){
virtualHostStr = AmqpConnection.DEFAULT_NAMESPACE;
}
}
Expand Down
2 changes: 1 addition & 1 deletion .../src/main/java/io/streamnative/pulsar/handlers/amqp/proxy/PulsarServiceLookupHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
import java.util.Optional;
import java.util.concurrent.CompletableFuture;
import lombok.extern.slf4j.Slf4j;
import org.apache.commons.lang.StringUtils;
import org.apache.commons.lang3.StringUtils;
import org.apache.commons.lang3.tuple.Pair;
import org.apache.pulsar.broker.PulsarService;
import org.apache.pulsar.broker.resources.MetadataStoreCacheLoader;
Expand Down
4 changes: 2 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,10 @@
<project.compiler.release>${maven.compiler.target}</project.compiler.release>

<!-- dependencies -->
<pulsar.version>4.1.0-SNAPSHOT</pulsar.version>
<pulsar.version>4.2.0-SNAPSHOT</pulsar.version>
<qpid-protocol-plugin.version>8.0.0</qpid-protocol-plugin.version>
<rabbitmq.version>5.8.0</rabbitmq.version>
<sn.bom.version>4.1.0-SNAPSHOT</sn.bom.version>
<sn.bom.version>4.2.0-SNAPSHOT</sn.bom.version>

<!-- test dependencies -->
<qpid-client-version>6.4.0</qpid-client-version>
Expand Down