Fixed token read from file #1227
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tuteng:Thanks for your contribution. For this PR, do we need to update docs? |
github-actions
bot
added
the
doc-info-missing
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new configuration option readTokenFromFile to control how JWT authentication tokens are provided to the sn-platform components. The change allows users to choose between reading tokens from files (existing behavior) or from Kubernetes secrets (new behavior).
- Added
readTokenFromFile: falseconfiguration option to JWT authentication settings - Modified authentication parameter logic to conditionally use file-based or secret-based token access
- Updated secret mounting logic to only mount token secrets when file-based reading is enabled
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| charts/sn-platform/values.yaml | Added readTokenFromFile configuration option with default value false |
| charts/sn-platform/templates/_helpers.tpl | Updated authentication logic to support both file and secret-based token reading |
| charts/sn-platform-slim/values.yaml | Added readTokenFromFile configuration option with default value false |
| charts/sn-platform-slim/templates/_helpers.tpl | Updated authentication logic to support both file and secret-based token reading |
labuladong
approved these changes
Jul 28, 2025
Member
Author
|
dup with #1230 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(If this PR fixes a github issue, please add
Fixes #<xyz>.)Fixes #
(or if this PR is one task of a github issue, please add
Master Issue: #<xyz>to link to the master issue.)Master Issue: #
Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)