Allow unset coordinator image #1228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@labuladong:Thanks for your contribution. For this PR, do we need to update docs? |
github-actions
bot
added
the
doc-info-missing
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the conditional logic for image configuration in Helm charts to allow the coordinator image to be optional. If the coordinator image is not set, the system will fallback to using component-specific images instead of relying solely on the coordinator configuration.
- Updates conditional logic to check both coordinator component enablement and coordinator image availability
- Wraps coordinator image specification in conditional blocks to handle unset scenarios
- Applies changes consistently across both sn-platform and sn-platform-slim charts
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| charts/sn-platform/templates/zookeeper/zookeeper-cluster.yaml | Updates condition to check both coordinator component and image availability |
| charts/sn-platform/templates/pulsar-coordinator/pulsar-coordinator.yaml | Wraps coordinator image in conditional block |
| charts/sn-platform/templates/proxy/proxy-cluster.yaml | Updates condition to check both coordinator component and image availability |
| charts/sn-platform/templates/broker/broker-cluster.yaml | Updates condition to check both coordinator component and image availability |
| charts/sn-platform/templates/bookkeeper/bookkeeper-cluster.yaml | Updates condition to check both coordinator component and image availability |
| charts/sn-platform-slim/templates/zookeeper/zookeeper-cluster.yaml | Updates condition to check both coordinator component and image availability |
| charts/sn-platform-slim/templates/pulsar-coordinator/pulsar-coordinator.yaml | Wraps coordinator image in conditional block |
| charts/sn-platform-slim/templates/proxy/proxy-cluster.yaml | Updates condition to check both coordinator component and image availability |
| charts/sn-platform-slim/templates/broker/broker-cluster.yaml | Updates condition to check both coordinator component and image availability |
| charts/sn-platform-slim/templates/bookkeeper/bookkeeper-cluster.yaml | Updates condition to check both coordinator component and image availability |
fantapsody
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If not set images.coordinator, will use images of every component