-
Notifications
You must be signed in to change notification settings - Fork 54
Fix proxy conn multi broker #1680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Technoboy-:Thanks for your contribution. For this PR, do we need to update docs? |
|
@Technoboy-:Thanks for your contribution. For this PR, do we need to update docs? |
|
@Technoboy-:Thanks for your contribution. For this PR, do we need to update docs? |


Motivation
When client uses the same connection to subscribe many topics, the mop proxy will create multi connections to the target broker. If some of the channel(proxy to broker) has no msg, the channel will be closed due to inactive event. In this case, the mop proxy could close the only one connection. and cause the client to be in a wrong behavior.
TestProxyConnectMultiBrokercould reproduce this issue.Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)