Fixes #288 - Operator does not revoke permissions when roles get removed from the list

[brunocascio]

Fixes #288

Motivation

When roles get removed from PulsarPermission's roles property, it must be removed from Pulsar permissions.

Modifications

• Added 2 methods (GetTopicPermissions and GetNamespacePermissions)
• Modified the reconcile permission logic, in order to grant or revoke permissions based on the incoming roles.
• Integrations tests.
• Updated conributing guidelines
• Replaces some hardcoded strings with env variables (backward compatible)

Verifying this change

• Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

• Added integration tests for PulsarPermission

Documentation

Check the box below.

Need to update docs?

• no-need-doc

Because it's a fix

[brunocascio]

Hello folks,

How should I proceed with this PR in order to get merged?

Thanks

[lhotari]

Hello folks,

How should I proceed with this PR in order to get merged?

Thanks

Thanks for the contribution @brunocascio. Great work! I'll help getting this merged.

[lhotari]

@freeznet Please review

[lhotari]

LGTM, good work @brunocascio

[lhotari]

It seems that this change causes a regression #310 . @brunocascio do you have a chance to take a look?

[brunocascio]

It seems that this change causes a regression #310 . @brunocascio do you have a chance to take a look?

maybe it's better to rollback this change due to it breaks currenty functionality of permissions.
Unfortunately I don't have the time now, but definetly I will look into it asap.