Skip to content

fix schema remove on existing resources #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
freeznet merged 4 commits into from
Jun 28, 2025
Merged

fix schema remove on existing resources #318

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e4985f2
fix 308 and 309
freeznet Jun 17, 2025
c4f197e
Merge branch 'main' into freeznet/fix-308-309
freeznet Jun 27, 2025
2f374f0
fix
freeznet Jun 27, 2025
880a60b
remove schema test case
freeznet Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions pkg/connection/reconcile_topic.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,13 +265,11 @@ func applySchema(pulsarAdmin admin.PulsarAdmin, topic *resourcev1alpha1.PulsarTo
return err
}
}
} else if schema != nil {
// Delete the schema when the schema exists and schema info is empty
log.Info("Deleting topic schema", "name", topic.Spec.Name)
if err := pulsarAdmin.DeleteSchema(topic.Spec.Name); err != nil {
return err
}
}
// Note: We intentionally do NOT delete existing schemas when schemaInfo is not specified.
// This preserves existing schemas that may have been created by producers/consumers,
// which is the expected behavior for most users. If schema deletion is needed,
// users should explicitly manage it through the Pulsar admin APIs.
return nil
}

Expand Down
Loading