fix: Use pointer types for boolean fields in PulsarSink to prevent omitempty issues#341
Merged
fix: Use pointer types for boolean fields in PulsarSink to prevent omitempty issues#341
Conversation
…itempty issues When boolean fields have omitempty tag and are set to false, they get omitted from JSON serialization causing the fields to disappear. This creates sync loops with GitOps tools like ArgoCD. Changed CleanupSubscription, RetainOrdering, RetainKeyOrdering, and AutoAck fields to use *bool instead of bool to properly handle false values. Fixes #3133 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
@freeznet:Thanks for your contribution. For this PR, do we need to update docs? |
github-actions
bot
added
the
doc-info-missing
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
license-eye has totally checked 449 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 356 | 2 | 91 | 0 |
Click to see the invalid file list
- charts/pulsar-resources-operator/crds/resource.streamnative.io_pulsarsinks.yaml
- config/crd/bases/resource.streamnative.io_pulsarsinks.yaml
charts/pulsar-resources-operator/crds/resource.streamnative.io_pulsarsinks.yaml
Show resolved
Hide resolved
…_pulsarsinks.yaml Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
maxsxu
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When boolean fields have omitempty tag and are set to false, they get omitted from JSON serialization causing the fields to disappear. This creates sync loops with GitOps tools like ArgoCD.
Changed CleanupSubscription, RetainOrdering, RetainKeyOrdering, and AutoAck fields to use *bool instead of bool to properly handle false values.
Fixes streamnative/eng-support-tickets#3133
Generated with Claude Code