Allow to change rustls crypto provider#362
Merged
BewareMyPower merged 1 commit intostreamnative:masterfrom Sep 29, 2025
Merged
Conversation
dsferruzza
force-pushed
the
remove-aws-lc-by-default
branch
from
0699d59 to
46fe4db
Compare
dsferruzza
changed the title
aws-lc-sys by default
dsferruzza
force-pushed
the
remove-aws-lc-by-default
branch
from
46fe4db to
88c975b
Compare
BewareMyPower
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I had the issue explained in #344 (and it was blocking me because
aws-lc-sysdoes not seem to be able to easily cross compile to ARMv6) so I made this change and it seems to fix it.I'm using my fork successfully in my app.
I'm not sure if this is the right way to fix this though: if I understand correctly, this relies on having either the
aws-lc-rsor theringRustls features enabled in the dependency tree(?)Another way could be to introduce the following features in this crate:
tokio-rustls-runtime-ringtokio-rustls-runtime-aws-lcasync-std-rustls-runtime-ringasync-std-rustls-runtime-aws-lcEach would enable the correct features in the Rustls-related dependencies.
The
tokio-rustls-runtimeandasync-std-rustls-runtimefeatures would be aliases to whatever should be the default.What do you think?