Skip to content

fix: producer is not closed at server side when batching is enabled#363

Merged
BewareMyPower merged 3 commits intomasterfrom
bewaremypower/fix-batch-close-producer
Sep 24, 2025
Merged

fix: producer is not closed at server side when batching is enabled#363
BewareMyPower merged 3 commits intomasterfrom
bewaremypower/fix-batch-close-producer

Conversation

@BewareMyPower
Copy link
Contributor

Fixes #360

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes issue #360 where the producer was not properly closed at the server side when batching is enabled. The fix ensures that when a batched producer is closed, the CloseProducer RPC call is properly sent to the server and the result is propagated back to the caller.

Key changes:

  • Modified the close mechanism to properly handle RPC communication between batch processing loops
  • Updated the close receiver to return the result of the CloseProducer RPC call instead of just a unit value
  • Added test coverage to verify that producers are removed from the server's publisher list after closing

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/producer.rs Modified batch processing to properly handle producer closure with RPC result propagation
src/lib.rs Added test to verify producer removal from server-side publisher list
Cargo.toml Added reqwest dependency for HTTP calls in tests

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

BewareMyPower and others added 2 commits September 22, 2025 23:55
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@BewareMyPower BewareMyPower merged commit 77fa24b into master Sep 24, 2025
7 checks passed
@BewareMyPower BewareMyPower deleted the bewaremypower/fix-batch-close-producer branch September 24, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression in 6.4.0: the producer is not closed at server side when batching is enabled

2 participants