fix: producer is not closed at server side when batching is enabled#363
Merged
BewareMyPower merged 3 commits intomasterfrom Sep 24, 2025
Merged
fix: producer is not closed at server side when batching is enabled#363BewareMyPower merged 3 commits intomasterfrom
BewareMyPower merged 3 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #360 where the producer was not properly closed at the server side when batching is enabled. The fix ensures that when a batched producer is closed, the CloseProducer RPC call is properly sent to the server and the result is propagated back to the caller.
Key changes:
- Modified the close mechanism to properly handle RPC communication between batch processing loops
- Updated the close receiver to return the result of the
CloseProducerRPC call instead of just a unit value - Added test coverage to verify that producers are removed from the server's publisher list after closing
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/producer.rs | Modified batch processing to properly handle producer closure with RPC result propagation |
| src/lib.rs | Added test to verify producer removal from server-side publisher list |
| Cargo.toml | Added reqwest dependency for HTTP calls in tests |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #360