Skip to content

Added crc32 integrity check in message.rs. Fixed little variable name typo #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BewareMyPower merged 6 commits into from
Nov 8, 2025
Merged

Added crc32 integrity check in message.rs. Fixed little variable name typo #369

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7eae5bf
Added crc32 check in message.rs. Fixed little variable name typo
LorenzoTettamanti Oct 27, 2025
6d8b100
Merge branch 'master' into message_improvements
LorenzoTettamanti Oct 27, 2025
d3da483
fixed useless use of format! during cargo clippy tests
LorenzoTettamanti Nov 3, 2025
70aa44c
Merge branch 'master' into message_improvements
LorenzoTettamanti Nov 7, 2025
df9a9eb
Merge branch 'streamnative:master' into message_improvements
LorenzoTettamanti Nov 8, 2025
3d96573
fix: Fixed code format
LorenzoTettamanti Nov 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 46 additions & 18 deletions src/message.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,13 +254,13 @@ impl tokio_util::codec::Encoder<Message> for Codec {
let crc_offset = buf.len();
buf.put_u32(0); // NOTE: Checksum (CRC32c). Overrwritten later to avoid copying.

let metdata_offset = buf.len();
let metadata_offset = buf.len();
buf.put_u32(metadata_size as u32);
payload.metadata.encode(&mut buf)?;
buf.put(&payload.data[..]);

let crc = CRC_CASTAGNOLI.checksum(&buf[metdata_offset..]);
let mut crc_buf: &mut [u8] = &mut buf[crc_offset..metdata_offset];
let crc = CRC_CASTAGNOLI.checksum(&buf[metadata_offset..]);
let mut crc_buf: &mut [u8] = &mut buf[crc_offset..metadata_offset];
crc_buf.put_u32(crc);
}
if dst.remaining_mut() < buf.len() {
Expand Down Expand Up @@ -308,13 +308,27 @@ impl tokio_util::codec::Decoder for Codec {
))
})?;

// TODO: Check crc32 of payload data

let metadata = Metadata::decode(payload_frame.metadata)?;
Some(Payload {
metadata,
data: buf.to_vec(),
})

//computing crc from metadata using the CRC_CASTAGNOLI checksum
let mut reconstructed_crc_data = Vec::new();
reconstructed_crc_data.put_u32(payload_frame.metadata_size);
reconstructed_crc_data.extend_from_slice(payload_frame.metadata);
reconstructed_crc_data.extend_from_slice(buf);

let computed_crc_32 = CRC_CASTAGNOLI.checksum(&reconstructed_crc_data);

let checksum32 = payload_frame.checksum;
if checksum32 == computed_crc_32 {
Some(Payload {
metadata,
data: buf.to_vec(),
})
} else {
return Err(ConnectionError::Decoding(
"Checksum mismatch, invalid payload".to_string(),
));
}
} else {
None
};
Expand Down Expand Up @@ -367,13 +381,13 @@ impl asynchronous_codec::Encoder for Codec {
let crc_offset = buf.len();
buf.put_u32(0); // NOTE: Checksum (CRC32c). Overrwritten later to avoid copying.

let metdata_offset = buf.len();
let metadata_offset = buf.len();
buf.put_u32(metadata_size as u32);
payload.metadata.encode(&mut buf)?;
buf.put(&payload.data[..]);

let crc = CRC_CASTAGNOLI.checksum(&buf[metdata_offset..]);
let mut crc_buf: &mut [u8] = &mut buf[crc_offset..metdata_offset];
let crc = CRC_CASTAGNOLI.checksum(&buf[metadata_offset..]);
let mut crc_buf: &mut [u8] = &mut buf[crc_offset..metadata_offset];
crc_buf.put_u32(crc);
}
if dst.remaining_mut() < buf.len() {
Expand Down Expand Up @@ -421,13 +435,27 @@ impl asynchronous_codec::Decoder for Codec {
))
})?;

// TODO: Check crc32 of payload data

let metadata = Metadata::decode(payload_frame.metadata)?;
Some(Payload {
metadata,
data: buf.to_vec(),
})

//computing crc from metadata using the CRC_CASTAGNOLI checksum
let mut reconstructed_crc_data = Vec::new();
reconstructed_crc_data.put_u32(payload_frame.metadata_size);
reconstructed_crc_data.extend_from_slice(payload_frame.metadata);
reconstructed_crc_data.extend_from_slice(buf);

let computed_crc_32 = CRC_CASTAGNOLI.checksum(&reconstructed_crc_data);

let checksum32 = payload_frame.checksum;
if checksum32 == computed_crc_32 {
Some(Payload {
metadata,
data: buf.to_vec(),
})
} else {
return Err(ConnectionError::Decoding(
"Checksum mismatch, invalid payload".to_string(),
));
}
} else {
None
};
Expand Down