discovery functions as tools #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and parameter validation across MCP tools. This change improves code consistency and readability by centralizing common functionalities.
There was a problem hiding this comment.
Pull Request Overview
This PR refactors various MCP tool handlers to use helper functions from the common package and adds the new "functions-as-tools" feature, enabling Pulsar Functions to be dynamically exposed as MCP tools. Key changes include updating function calls (e.g. getOptions, requiredParam, optionalParam) to their common counterparts, bumping the mcp-go dependency version, and documentation and Makefile updates for licensing and feature support.
Reviewed Changes
Copilot reviewed 68 out of 68 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/mcp/prompts.go | Replace local utility calls with common.* helper functions |
| pkg/mcp/kafka_client_produce_tools.go | Update parameter retrieval to use common.RequiredParam/OptionalParam |
| pkg/mcp/kafka_client_consume_tools.go | Update parameter retrieval to use common.RequiredParam/OptionalParam |
| pkg/mcp/kafka_admin_topics_tools.go | Replace local utility calls with common.* helper functions |
| pkg/mcp/kafka_admin_sr_tools.go | Update parameter retrieval to use common.RequiredParam/OptionalParam |
| pkg/mcp/kafka_admin_partitions_tools.go | Replace local utility calls with common.* helper functions |
| pkg/mcp/kafka_admin_groups_tools.go | Replace local utility calls with common.* helper functions |
| pkg/mcp/kafka_admin_connect_tools.go | Update parameter retrieval and conversion to use common.* functions |
| pkg/mcp/features.go | Add new feature constant "functions-as-tools" |
| pkg/mcp/context_utils.go | Replace internal calls with common.* helper functions |
| pkg/mcp/context_tools.go | Replace context value retrieval and parameter functions with common.* |
| pkg/common/utils.go | Rename utility functions for consistency and add numeric type checks |
| pkg/cmd/mcp/stdio.go | Update context key usage to refer to common.OptionsKey |
| pkg/cmd/mcp/sse.go | Update context key and server shutdown calls to use common values |
| go.work.sum & go.mod | Bump mcp-go dependency to v0.28.0 and add additional dependencies |
| docs/tools/functions_as_tools.md | Add documentation for dynamically exposing Pulsar Functions as tools |
| README.md | Update feature table with "functions-as-tools" entry |
| Makefile & .licenserc.yaml | Add/update licensing tasks and configuration |
jiangpengcheng
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
making pulsar functions be able to exported as MCP tools