Skip to content

fix: features flag not cover all tools #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
freeznet merged 1 commit into from
May 9, 2025
Merged

fix: features flag not cover all tools #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/mcp/kafka_admin_connect_tools.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ import (
)

func KafkaAdminAddKafkaConnectTools(s *server.MCPServer, readOnly bool, features []string) {
if !slices.Contains(features, string(FeatureKafkaAdminKafkaConnect)) && !slices.Contains(features, string(FeatureAll)) && !slices.Contains(features, string(FeatureAllKafka)) {
if !slices.Contains(features, string(FeatureKafkaAdminKafkaConnect)) && !slices.Contains(features, string(FeatureAll)) && !slices.Contains(features, string(FeatureAllKafka)) && !slices.Contains(features, string(FeatureKafkaAdmin)) {
return
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/mcp/kafka_admin_sr_tools.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import (
)

func KafkaAdminAddSchemaRegistryTools(s *server.MCPServer, readOnly bool, features []string) {
if !slices.Contains(features, string(FeatureKafkaAdminSchemaRegistry)) && !slices.Contains(features, string(FeatureAll)) && !slices.Contains(features, string(FeatureAllKafka)) {
if !slices.Contains(features, string(FeatureKafkaAdminSchemaRegistry)) && !slices.Contains(features, string(FeatureAll)) && !slices.Contains(features, string(FeatureAllKafka)) && !slices.Contains(features, string(FeatureKafkaAdmin)) {
return
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/mcp/pulsar_admin_brokers_stats_tools.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import (

// PulsarAdminAddBrokerStatsTools adds broker-stats related tools to the MCP server
func PulsarAdminAddBrokerStatsTools(s *server.MCPServer, readOnly bool, features []string) {
if !slices.Contains(features, string(FeaturePulsarAdminBrokersStatus)) && !slices.Contains(features, string(FeatureAll)) && !slices.Contains(features, string(FeatureAllPulsar)) {
if !slices.Contains(features, string(FeaturePulsarAdminBrokersStatus)) && !slices.Contains(features, string(FeatureAll)) && !slices.Contains(features, string(FeatureAllPulsar)) && !slices.Contains(features, string(FeaturePulsarAdmin)) {
return
}
// Unified broker stats tool
Expand Down
2 changes: 1 addition & 1 deletion pkg/mcp/pulsar_admin_brokers_tools.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import (

// PulsarAdminAddBrokersTools adds broker-related tools to the MCP server
func PulsarAdminAddBrokersTools(s *server.MCPServer, readOnly bool, features []string) {
if !slices.Contains(features, string(FeaturePulsarAdminBrokers)) && !slices.Contains(features, string(FeatureAll)) && !slices.Contains(features, string(FeatureAllPulsar)) {
if !slices.Contains(features, string(FeaturePulsarAdminBrokers)) && !slices.Contains(features, string(FeatureAll)) && !slices.Contains(features, string(FeatureAllPulsar)) && !slices.Contains(features, string(FeaturePulsarAdmin)) {
return
}
// Create a single unified broker tool to replace multiple individual tools
Expand Down
2 changes: 1 addition & 1 deletion pkg/mcp/pulsar_admin_cluster_tools.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ import (

// PulsarAdminAddClusterTools adds cluster-related tools to the MCP server
func PulsarAdminAddClusterTools(s *server.MCPServer, readOnly bool, features []string) {
if !slices.Contains(features, string(FeaturePulsarAdminClusters)) && !slices.Contains(features, string(FeatureAll)) && !slices.Contains(features, string(FeatureAllPulsar)) {
if !slices.Contains(features, string(FeaturePulsarAdminClusters)) && !slices.Contains(features, string(FeatureAll)) && !slices.Contains(features, string(FeatureAllPulsar)) && !slices.Contains(features, string(FeaturePulsarAdmin)) {
return
}
// Create a single unified cluster tool
Expand Down
2 changes: 1 addition & 1 deletion pkg/mcp/pulsar_admin_functions_tools.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ import (

// PulsarAdminAddFunctionsTools adds a unified function-related tool to the MCP server
func PulsarAdminAddFunctionsTools(s *server.MCPServer, readOnly bool, features []string) {
if !slices.Contains(features, string(FeaturePulsarAdminFunctions)) && !slices.Contains(features, string(FeatureAll)) && !slices.Contains(features, string(FeatureAllPulsar)) {
if !slices.Contains(features, string(FeaturePulsarAdminFunctions)) && !slices.Contains(features, string(FeatureAll)) && !slices.Contains(features, string(FeatureAllPulsar)) && !slices.Contains(features, string(FeaturePulsarAdmin)) {
return
}
// Create a single unified tool for all function operations
Expand Down
2 changes: 1 addition & 1 deletion pkg/mcp/pulsar_admin_functions_worker_tools.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import (

// PulsarAdminAddFunctionsWorkerTools adds functions worker-related tools to the MCP server
func PulsarAdminAddFunctionsWorkerTools(s *server.MCPServer, readOnly bool, features []string) {
if !slices.Contains(features, string(FeaturePulsarAdminFunctionsWorker)) && !slices.Contains(features, string(FeatureAll)) && !slices.Contains(features, string(FeatureAllPulsar)) {
if !slices.Contains(features, string(FeaturePulsarAdminFunctionsWorker)) && !slices.Contains(features, string(FeatureAll)) && !slices.Contains(features, string(FeatureAllPulsar)) && !slices.Contains(features, string(FeaturePulsarAdmin)) {
return
}
// Create a single unified functions worker tool
Expand Down
2 changes: 1 addition & 1 deletion pkg/mcp/pulsar_admin_namespace_policy_tools.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ import (

// PulsarAdminAddNamespacePolicyTools adds namespace policy-related tools to the MCP server
func PulsarAdminAddNamespacePolicyTools(s *server.MCPServer, readOnly bool, features []string) {
if !slices.Contains(features, string(FeaturePulsarAdminNamespacePolicy)) && !slices.Contains(features, string(FeatureAll)) && !slices.Contains(features, string(FeatureAllPulsar)) {
if !slices.Contains(features, string(FeaturePulsarAdminNamespacePolicy)) && !slices.Contains(features, string(FeatureAll)) && !slices.Contains(features, string(FeatureAllPulsar)) && !slices.Contains(features, string(FeaturePulsarAdmin)) {
return
}
namespaceGetPoliciesTool := mcp.NewTool("pulsar_admin_namespace_policy_get",
Expand Down
2 changes: 1 addition & 1 deletion pkg/mcp/pulsar_admin_namespace_tools.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ import (

// PulsarAdminAddNamespaceTools adds namespace-related tools to the MCP server
func PulsarAdminAddNamespaceTools(s *server.MCPServer, readOnly bool, features []string) {
if !slices.Contains(features, string(FeaturePulsarAdminNamespaces)) && !slices.Contains(features, string(FeatureAll)) && !slices.Contains(features, string(FeatureAllPulsar)) {
if !slices.Contains(features, string(FeaturePulsarAdminNamespaces)) && !slices.Contains(features, string(FeatureAll)) && !slices.Contains(features, string(FeatureAllPulsar)) && !slices.Contains(features, string(FeaturePulsarAdmin)) {
return
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/mcp/pulsar_admin_nsisolationpolicy_tools.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ import (

// PulsarAdminAddNsIsolationPolicyTools adds namespace isolation policy related tools to the MCP server
func PulsarAdminAddNsIsolationPolicyTools(s *server.MCPServer, readOnly bool, features []string) {
if !slices.Contains(features, string(FeaturePulsarAdminNsIsolationPolicy)) && !slices.Contains(features, string(FeatureAll)) && !slices.Contains(features, string(FeatureAllPulsar)) {
if !slices.Contains(features, string(FeaturePulsarAdminNsIsolationPolicy)) && !slices.Contains(features, string(FeatureAll)) && !slices.Contains(features, string(FeatureAllPulsar)) && !slices.Contains(features, string(FeaturePulsarAdmin)) {
return
}

Expand Down
18 changes: 9 additions & 9 deletions pkg/mcp/pulsar_admin_packages_tools.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
// Licensed to Elasticsearch B.V. under one or more contributor
// license agreements. See the NOTICE file distributed with
// this work for additional information regarding copyright
// ownership. Elasticsearch B.V. licenses this file to you under
// the Apache License, Version 2.0 (the "License"); you may
// not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
Expand All @@ -32,7 +32,7 @@ import (

// PulsarAdminAddPackagesTools adds package-related tools to the MCP server
func PulsarAdminAddPackagesTools(s *server.MCPServer, readOnly bool, features []string) {
if !slices.Contains(features, string(FeaturePulsarAdminPackages)) && !slices.Contains(features, string(FeatureAll)) && !slices.Contains(features, string(FeatureAllPulsar)) {
if !slices.Contains(features, string(FeaturePulsarAdminPackages)) && !slices.Contains(features, string(FeatureAll)) && !slices.Contains(features, string(FeatureAllPulsar)) && !slices.Contains(features, string(FeaturePulsarAdmin)) {
return
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/mcp/pulsar_admin_resourcequotas_tools.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ import (

// PulsarAdminAddResourceQuotasTools adds resource quotas-related tools to the MCP server
func PulsarAdminAddResourceQuotasTools(s *server.MCPServer, readOnly bool, features []string) {
if !slices.Contains(features, string(FeaturePulsarAdminResourceQuotas)) && !slices.Contains(features, string(FeatureAll)) && !slices.Contains(features, string(FeatureAllPulsar)) {
if !slices.Contains(features, string(FeaturePulsarAdminResourceQuotas)) && !slices.Contains(features, string(FeatureAll)) && !slices.Contains(features, string(FeatureAllPulsar)) && !slices.Contains(features, string(FeaturePulsarAdmin)) {
return
}
// Add unified resource quotas management tool
Expand Down
2 changes: 1 addition & 1 deletion pkg/mcp/pulsar_admin_schemas_tools.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ import (

// PulsarAdminAddSchemasTools adds schema-related tools to the MCP server
func PulsarAdminAddSchemasTools(s *server.MCPServer, readOnly bool, features []string) {
if !slices.Contains(features, string(FeaturePulsarAdminSchemas)) && !slices.Contains(features, string(FeatureAll)) && !slices.Contains(features, string(FeatureAllPulsar)) {
if !slices.Contains(features, string(FeaturePulsarAdminSchemas)) && !slices.Contains(features, string(FeatureAll)) && !slices.Contains(features, string(FeatureAllPulsar)) && !slices.Contains(features, string(FeaturePulsarAdmin)) {
return
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/mcp/pulsar_admin_sinks_tools.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ import (

// PulsarAdminAddSinksTools adds a unified sink-related tool to the MCP server
func PulsarAdminAddSinksTools(s *server.MCPServer, readOnly bool, features []string) {
if !slices.Contains(features, string(FeaturePulsarAdminSinks)) && !slices.Contains(features, string(FeatureAll)) && !slices.Contains(features, string(FeatureAllPulsar)) {
if !slices.Contains(features, string(FeaturePulsarAdminSinks)) && !slices.Contains(features, string(FeatureAll)) && !slices.Contains(features, string(FeatureAllPulsar)) && !slices.Contains(features, string(FeaturePulsarAdmin)) {
return
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/mcp/pulsar_admin_sources_tools.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ import (

// PulsarAdminAddSourcesTools adds a unified source-related tool to the MCP server
func PulsarAdminAddSourcesTools(s *server.MCPServer, readOnly bool, features []string) {
if !slices.Contains(features, string(FeaturePulsarAdminSources)) && !slices.Contains(features, string(FeatureAll)) && !slices.Contains(features, string(FeatureAllPulsar)) {
if !slices.Contains(features, string(FeaturePulsarAdminSources)) && !slices.Contains(features, string(FeatureAll)) && !slices.Contains(features, string(FeatureAllPulsar)) && !slices.Contains(features, string(FeaturePulsarAdmin)) {
return
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/mcp/pulsar_admin_subscription_tools.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ import (

// PulsarAdminAddSubscriptionTools adds subscription-related tools to the MCP server
func PulsarAdminAddSubscriptionTools(s *server.MCPServer, readOnly bool, features []string) {
if !slices.Contains(features, string(FeaturePulsarAdminSubscriptions)) && !slices.Contains(features, string(FeatureAll)) && !slices.Contains(features, string(FeatureAllPulsar)) {
if !slices.Contains(features, string(FeaturePulsarAdminSubscriptions)) && !slices.Contains(features, string(FeatureAll)) && !slices.Contains(features, string(FeatureAllPulsar)) && !slices.Contains(features, string(FeaturePulsarAdmin)) {
return
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/mcp/pulsar_admin_tenant_tools.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ import (

// PulsarAdminAddTenantTools adds tenant-related tools to the MCP server
func PulsarAdminAddTenantTools(s *server.MCPServer, readOnly bool, features []string) {
if !slices.Contains(features, string(FeaturePulsarAdminTenants)) && !slices.Contains(features, string(FeatureAll)) && !slices.Contains(features, string(FeatureAllPulsar)) {
if !slices.Contains(features, string(FeaturePulsarAdminTenants)) && !slices.Contains(features, string(FeatureAll)) && !slices.Contains(features, string(FeatureAllPulsar)) && !slices.Contains(features, string(FeaturePulsarAdmin)) {
return
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/mcp/pulsar_admin_topic_policy_tools.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ import (

// PulsarAdminAddTopicPolicyTools adds topic policy-related tools to the MCP server
func PulsarAdminAddTopicPolicyTools(s *server.MCPServer, readOnly bool, features []string) {
if !slices.Contains(features, string(FeaturePulsarAdminTopicPolicy)) && !slices.Contains(features, string(FeatureAll)) && !slices.Contains(features, string(FeatureAllPulsar)) {
if !slices.Contains(features, string(FeaturePulsarAdminTopicPolicy)) && !slices.Contains(features, string(FeatureAll)) && !slices.Contains(features, string(FeatureAllPulsar)) && !slices.Contains(features, string(FeaturePulsarAdmin)) {
return
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/mcp/pulsar_admin_topic_tools.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ import (

// PulsarAdminAddTopicTools adds topic-related tools to the MCP server
func PulsarAdminAddTopicTools(s *server.MCPServer, readOnly bool, features []string) {
if !slices.Contains(features, string(FeaturePulsarAdminTopics)) && !slices.Contains(features, string(FeatureAll)) && !slices.Contains(features, string(FeatureAllPulsar)) {
if !slices.Contains(features, string(FeaturePulsarAdminTopics)) && !slices.Contains(features, string(FeatureAll)) && !slices.Contains(features, string(FeatureAllPulsar)) && !slices.Contains(features, string(FeaturePulsarAdmin)) {
return
}

Expand Down