Skip to content

Conversation

@maxsxu
Copy link
Member

@maxsxu maxsxu commented May 13, 2025

Motivation

This is follow up of #157

Modifications

  • Use conditional set env rather than null value, so we can leverage the default value, otherwise null value can break it.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

  • no-need-doc

@maxsxu maxsxu requested a review from a team as a code owner May 13, 2025 15:30
@github-actions github-actions bot added the no-need-doc This pr does not need any document label May 13, 2025
@maxsxu maxsxu requested a review from dpappa May 13, 2025 15:31
Copy link
Member

@dpappa dpappa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxsxu maxsxu merged commit 7a4e9c3 into master May 14, 2025
4 checks passed
@maxsxu maxsxu deleted the max/fix-null branch May 14, 2025 07:48
maxsxu pushed a commit that referenced this pull request May 14, 2025
🤖 I have created a release *beep* *boop*
---


##
[4.3.1](v4.3.0...v4.3.1)
(2025-05-14)


### Bug Fixes

* conditional set env rather than null value
([#159](#159))
([7a4e9c3](7a4e9c3))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-need-doc This pr does not need any document

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants