Skip to content

fix: Rename account id to google service account id #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tuteng merged 2 commits into from
Apr 3, 2025
Merged

fix: Rename account id to google service account id #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ff9ba1
Rename account id to google service account id
tuteng Apr 2, 2025
d6e68cb
Add comment
tuteng Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion examples/gcp/volume-access/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ module "sn_managed_cloud_access_bucket" {
"<your-ursa-cluster-project-name>"
]

account_id = "<your-google-service-account-id>"
# https://cloud.google.com/iam/docs/service-accounts-create#creating
google_service_account_id = "<your-google-service-account-id>"

buckets = [
"<your-gcs-bucket-path>"
Expand Down
4 changes: 2 additions & 2 deletions modules/gcp/volume-access/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@ locals {

}
resource "google_service_account" "gsa" {
account_id = var.account_id
account_id = var.google_service_account_id
project = var.project
display_name = "StreamNative Cloud Control Plane access bucket service account."
display_name = "StreamNative Cloud access bucket service account."
}

resource "google_storage_bucket_iam_member" "gcs" {
Expand Down
4 changes: 2 additions & 2 deletions modules/gcp/volume-access/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ variable "streamnative_vendor_access_gsa" {
description = "The GSA will be used by StreamnNative cloud."
}

variable "account_id" {
variable "google_service_account_id" {
type = string
description = "Google Service Account ID, <id>@<your-project>.iam.gserviceaccount.com"
description = "Google Service Account ID, <id>@<your-project>.iam.gserviceaccount.com, ref https://cloud.google.com/iam/docs/service-accounts-create#creating"
}

variable "project" {
Expand Down
Loading