Skip to content

refactor: remove generated protobuf files from the repo #2842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
juslesan merged 32 commits into from
Dec 19, 2024
Merged

refactor: remove generated protobuf files from the repo #2842

juslesan merged 32 commits into from
Dec 19, 2024

Conversation

@juslesan
Copy link
Contributor

@juslesan juslesan commented Oct 23, 2024 •
edited
Loading

Summary

Removing generated protobuf files from the public repo

Future improvements

  • What should we do with the proto-rpc package's generate protobuf code? Currently the solution requires generateing the code for eslint, check, and test separately. We don't want to include the building of the test files in pre-build.
  • Could look into pruning all of the bootstrapped packages in the Dockerfile. Based on a quick test the size of the image is the same if only the node is pruned or if all sub packages are pruned separately.

@linear
Copy link

linear bot commented Oct 23, 2024

NET-1371 Fix problem with building protobuf files in linux to get rid of generated files in the repo

@github-actions github-actions bot added network Related to Network Package dht Related to DHT package proto-rpc sdk ci Related to CI configuration labels Oct 23, 2024
@juslesan juslesan mentioned this pull request Dec 2, 2024
Merged
juslesan added a commit that referenced this pull request Dec 3, 2024
@juslesan
fix(network): Revert backwards incompatible PR #2820 (#2922)
7465d20 
Reverting PR #2820 due to backwards incompatibility with production. The
typeUrl of the PeerDescriptors in the Any protobuf message has changes
from `dht.PeerDescriptor` to `peerDescriptor.PeerDescriptor` in this
change. This makes it impossible to parse the stream entry points stored
stored in the DHT causing stream joining to not work.

The clean up of generated protobuf code will be implemented in #2842
@juslesan juslesan requested a review from teogeb December 5, 2024 14:10
@juslesan juslesan marked this pull request as ready for review December 19, 2024 12:44
@teogeb teogeb mentioned this pull request Dec 19, 2024
Merged
@teogeb teogeb mentioned this pull request Dec 19, 2024
Merged
@juslesan juslesan merged commit 84ec8fb into main Dec 19, 2024
24 checks passed
@juslesan juslesan deleted the NET-1371 branch December 19, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@teogeb teogeb teogeb approved these changes

Assignees

No one assigned

Labels

ci Related to CI configuration dht Related to DHT package network Related to Network Package proto-rpc sdk

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@juslesan @teogeb