feat(sdk)!: Remove StreamrClient#findOperators()
#2876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juslesan
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change as this changes the API
Removed the method from public API by annotating it as
@internal.The API of this method and some other related methods may change soon (NET-1374).
Background
The method signature use internal
StreamIDtype. If we re-include the method to public API that parameter type should be changed tostreamIdOrPath: string.Also the magic numbers (
maxQueryResults,maxHeartbeatAgeHours) should be configurable, or the method name should reflect the fact that it finds only a subset of operators? Note also that query currently excludes non-TLS operator nodes. We could either add a configuration option to handle that exclusion or rename the method (e.g.findConnectableOperators()).