refactor(sdk)!: Stateless Stream
#2883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teogeb
force-pushed
the
sdk-stateless-stream
branch
from
65e60f7 to
fa8fd69
Compare
teogeb
force-pushed
the
sdk-stateless-stream
branch
from
7a6d5ec to
eb3f231
Compare
teogeb
added a commit
that referenced
this pull request
Nov 18, 2024
Moved two Ethereum function selector utils from `FakeJsonRpcServer` to test utils. These are soon needed in #2883. Also refactored methods (and one `FakeJsonRpcServer` usage) to use the `id` utils from ethers (https://github.com/ethers-io/ethers.js/blob/9e7e7f3e2f2d51019aaa782e6290e079c38332fb/src.ts/hash/id.ts#L16). It does the same hash calculation as our implementation. Note that the return value of the functions now includes the `0x` prefix. It is therefore compatible e.g. with `ethers` `FunctionFragment.getSelector()` method (https://github.com/ethers-io/ethers.js/blob/9e7e7f3e2f2d51019aaa782e6290e079c38332fb/src.ts/abi/fragments.ts#L1449).
harbu
reviewed
Nov 20, 2024
harbu
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking changes as this changes the API
Streaminstances no longer have metadata field. Instead the metadata is queried fromStreamRegistry.StreamRegistryalready caches the metadata. Now we explicity populate the cache e.g. insearchStreams()(which queriesid+metadata) from The Graph).API
These
Streammethods are now async:getMetadata()getPartitionCount()getDescription()getStorageDayCount()Also added
StreamrClient#getStreamMetadata()method which is used byStream#getMetadata().Testing
Added new end-to-end tests to assert cache population logic. The new
ProxyHttpServerhelper class which is needed by those tests.