test(sdk): Unify toThrowStreamrError()
#2894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teogeb
force-pushed
the
unify-sdk-toThrowStreamrError
branch
from
828bab6 to
e7c049c
Compare
juslesan
approved these changes
Nov 26, 2024
Co-authored-by: Santeri Juslenius <[email protected]>
teogeb
added a commit
that referenced
this pull request
Dec 11, 2024
## Background Jest error messages typically contain ANSI color codes. In `customMatchers.test.ts`, we asserted these messages without accounting for the color codes, which caused test failures. However, the tests passed in environments where colors were disabled (e.g., CI). These test cases were added in #2894. ## Changes Modified the assertions to allow color codes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output is now similar to
toEqualPeerDescriptor()(see #2892).The custom matcher implementation now uses stricter types. Also improved output when the error thrown is a primitive value.