refactor(sdk): Improve InternalPermissionQuery type safety
#2925
+27
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mondoreale
approved these changes
Dec 4, 2024
Contributor
mondoreale
left a comment
mondoreale
left a comment
There was a problem hiding this comment.
Sounds reasonable. Looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type of
streamIdfield is nowStreamIDinstead ofstring.Also remove obsolete
toInternalPermissionQuery()call inStream#hasPermissions(). There is no need to convert the query as the we call the client method which does the same conversion.Also fixed method signatures in
FakeStreamRegistryso that they matchedStreamRegistrymethods.