Skip to content

Conversation

@mondoreale
Copy link
Contributor

This pull request updates the packaging configuration for several packages, focusing on standardizing the files field in package.json and cleaning up ignored files. The main goal is to ensure that only the necessary files are included in published npm packages, improving consistency and reducing package size.

Changes

Packaging and file inclusion improvements:

  • Standardized the files field in package.json across multiple packages to consistently include dist, exclude *.tsbuildinfo, and selectively include or remove README.md and LICENSE files. (packages/autocertifier-client/package.json [1] packages/autocertifier-server/package.json [2] packages/test-utils/package.json [3] packages/trackerless-network/package.json [4] packages/browser-test-runner/package.json [5]
  • Added a files field to packages/browser-test-runner/package.json to ensure only the necessary files are published.
  • Remove .npmignore in packages/autocertifier-client – the files field now controls published content.1

Footnotes

  1. autocertifier-client was the only package with .npmignore. It also had files in its package.json. Now it's just like all the other packages – driven by the files field *only*.

@mondoreale mondoreale requested a review from Copilot December 14, 2025 18:51
@github-actions github-actions bot added network Related to Network Package test-utils Related to Test Utils Package labels Dec 14, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request standardizes the files field configuration across multiple npm packages in the monorepo. The changes ensure that only necessary files are included in published packages by aligning patterns and removing references to non-existent files.

Key changes:

  • Standardizes the files field syntax across packages (e.g., dist/dist, specific tsbuildinfo paths → !*.tsbuildinfo wildcard)
  • Removes LICENSE file references from packages where the file doesn't exist in the package directory
  • Adds files field to browser-test-runner to control published content
  • Removes .npmignore from autocertifier-client in favor of the files field approach used by all other packages

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/trackerless-network/package.json Removes non-existent LICENSE file from published package contents
packages/test-utils/package.json Standardizes directory pattern (dist/dist) and tsbuildinfo exclusion to match other packages
packages/browser-test-runner/package.json Adds files field to control published content, including LICENSE file
packages/autocertifier-server/package.json Removes non-existent LICENSE file reference from published package contents
packages/autocertifier-client/package.json Removes references to non-existent README.md and LICENSE files
packages/autocertifier-client/.npmignore Deletes .npmignore file to align with other packages that use only the files field

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mondoreale
Copy link
Contributor Author

mondoreale commented Dec 14, 2025

Mostly clean-up, and mostly about autocertifier-client where the redundant .npmignore is removed.

I've double-checked the lists of packed files with npm pack --dry-run. FYI.

Merging in.

@mondoreale mondoreale merged commit 3c97533 into main Dec 14, 2025
48 of 49 checks passed
@mondoreale mondoreale deleted the whitelist-packed-files-via-package-json branch December 14, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

network Related to Network Package test-utils Related to Test Utils Package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants