Skip to content

refactor: Drop "dom" lib from SDK's TypeScript config and clarify environment usage #3303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mondoreale merged 2 commits into from
Dec 16, 2025
Merged

refactor: Drop "dom" lib from SDK's TypeScript config and clarify environment usage #3303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ebd427a
Use default `lib` for the SDK
mondoreale Dec 15, 2025
b3f9c28
Actually, use `es2021`
mondoreale Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/sdk/src/encryption/RSAKeyPair.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
/**
* @todo This file contains code for both browser and Node.js environments. Consider
* making it environment-specific (using separate files or conditional exports), and
* remove the following "dom" lib reference when done.
*/
/// <reference lib="dom" />

import crypto from 'crypto'
import { promisify } from 'util'
import { KeyExchangeKeyPair } from './KeyExchangeKeyPair'
Expand Down
3 changes: 2 additions & 1 deletion packages/sdk/src/identity/ECDSAKeyPairIdentity.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { hexToBinary, EcdsaSecp256r1 } from '@streamr/utils'
import { KeyPairIdentity } from './KeyPairIdentity'
import { SignatureType } from '@streamr/trackerless-network'
import { StrictStreamrClientConfig } from '../Config'
import type { webcrypto } from 'crypto'

const signingUtil = new EcdsaSecp256r1()

Expand All @@ -10,7 +11,7 @@ const signingUtil = new EcdsaSecp256r1()
*/
export class ECDSAKeyPairIdentity extends KeyPairIdentity {

private cachedJWK: JsonWebKey | undefined
private cachedJWK: webcrypto.JsonWebKey | undefined

assertValidKeyPair(): void {
signingUtil.assertValidKeyPair(this.publicKey, this.privateKey)
Expand Down
2 changes: 1 addition & 1 deletion packages/sdk/tsconfig.jest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"extends": "../../tsconfig.jest.json",
"compilerOptions": {
"lib": ["es2021", "dom"],
"lib": ["es2021"],
"experimentalDecorators": true,
"emitDecoratorMetadata": true,
"noImplicitOverride": false
Expand Down
2 changes: 1 addition & 1 deletion packages/sdk/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"compilerOptions": {
"outDir": "dist",
"declarationDir": "dist/types",
"lib": ["es2021", "dom"],
"lib": ["es2021"],
"experimentalDecorators": true,
"emitDecoratorMetadata": true,
"noImplicitOverride": false
Expand Down