refactor: Avoid NodeJS-specific module (use explicit logger scopes)

[mondoreale]

This pull request standardizes logger initialization throughout the codebase by replacing the use of new Logger(module) with a more descriptive string identifier for each module or class. This improves the clarity of log messages and makes it easier to trace logs back to their source components.

Changes

Logger initialization updates (all changes):

• Replaced new Logger(module) with new Logger('<ClassOrFileName>') in all relevant files across autocertifier-client, autocertifier-server, cdn-location, and dht packages to ensure consistent and descriptive logging.

• Replaced all occurrences of loggerFactory.createLogger(module) with loggerFactory.createLogger('<ClassOrFileName>') in all relevant files across the monorepo.

Future steps

Note

Because logger instances are created at the top level of each module, simply importing the package into a host project will eagerly instantiate all associated loggers, even if the corresponding exports are never used.

1. Many modules currently instantiate a logger at import time (e.g. new Logger('Foo')). This introduces a side effect during module evaluation, which prevents effective tree-shaking of both the module itself and the Logger implementation.

   A future improvement would be to decouple logger creation from module imports by moving initialization behind explicit factory functions or lazy accessors. This would reduce import-time side effects and allow unused modules (and the logger code) to be safely tree-shaken by the bundler.

2. Logger was the key reason why we kept using (and polyfilling) module. Consumers will be able to drop that env-specific "dependency" from their setups soon.

[Copilot]

Pull request overview

This pull request removes the NodeJS-specific module dependency from logger initialization across the entire codebase by replacing new Logger(module) with explicit string identifiers like new Logger('ClassName'). This change improves portability to non-NodeJS environments and makes log tracing more explicit and descriptive.

Key changes:

• Replaced all new Logger(module) calls with new Logger('<descriptive-string>') across all packages
• Exported LoggerModule type from utils package for consistent typing
• Updated LoggerFactory.createLogger parameter from module: NodeJS.Module to loggerModule: LoggerModule

Reviewed changes

Copilot reviewed 166 out of 168 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
packages/utils/src/Logger.ts	Exported LoggerModule type to make it publicly available
packages/utils/src/exports.ts	Added LoggerModule to public exports
packages/utils/test/Logger.test.ts	Updated test logger to use string identifier 'Logger'
packages/utils/src/executeSafePromise.ts	Changed logger name from module to 'executeSafePromise'
packages/utils/src/TheGraphClient.ts	Changed logger name to 'TheGraphClient'
packages/sdk/src/utils/LoggerFactory.ts	Updated parameter name from module to loggerModule and imported LoggerModule type
packages/sdk/src/utils/waitForAssignmentsToPropagate.ts	Changed logger creation to use 'waitForAssignmentsToPropagate'
packages/sdk/src/utils/utils.ts	Changed logger name to 'utils'
packages/sdk/src/utils/persistence/ServerPersistence.ts	Updated LoggerFactory usage to use 'ServerPersistence'
packages/sdk/src/utils/LoggingJsonRpcProvider.ts	Changed logger name to 'LoggingJsonRpcProvider'
packages/sdk/src/subscribe/*.ts	Updated all subscription-related files to use descriptive class/file names
packages/sdk/src/encryption/*.ts	Updated encryption-related files to use class names
packages/sdk/src/contracts/*.ts	Updated all contract files to use descriptive names
packages/sdk/src/StreamrClient.ts	Changed logger to 'StreamrClient'
packages/sdk/src/ProxyNodeFinder.ts	Changed logger to 'ProxyNodeFinder'
packages/sdk/src/NetworkNodeFacade.ts	Changed logger to 'NetworkNodeFacade'
packages/sdk/test/**/*.ts	Updated all test files to use descriptive test file names
packages/trackerless-network/src/**/*.ts	Updated all network layer files with descriptive names
packages/trackerless-network/test/**/*.ts	Updated test files with descriptive test identifiers
packages/proto-rpc/src/*.ts	Updated RPC-related files with class names
packages/node/src/**/*.ts	Updated broker node files with descriptive names
packages/node/test/**/*.ts	Updated test files with descriptive test identifiers
packages/test-utils/src/index.ts	Changed logger to generic 'index' identifier
packages/geoip-location/src/*.ts	Updated geolocation files with descriptive names
packages/geoip-location/test/*.ts	Updated test with descriptive identifier
packages/dht/src/**/*.ts	Updated all DHT files with class/file names
packages/dht/test/**/*.ts	Updated test files with descriptive test identifiers
packages/cdn-location/src/*.ts	Updated CDN location files with descriptive names
packages/cdn-location/test/*.ts	Updated test with descriptive identifier
packages/autocertifier-server/src/*.ts	Updated autocertifier server files with class names
packages/autocertifier-server/bin/*.ts	Updated script with descriptive identifier
packages/autocertifier-client/src/*.ts	Updated client files with class names
packages/cli-tools/bin/*.ts	Updated CLI tool with descriptive identifier

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The logger identifier 'utils' is too generic and could be ambiguous in test logs. Since this is a test utility file in the SDK package, consider using 'sdk-test-utils' or 'test-utils' to make it easier to distinguish from other similarly named files when reading logs.

[mondoreale]

@copilot open a new pull request to apply changes based on this feedback

[Copilot]

@mondoreale I've opened a new pull request, #3314, to work on those changes. Once the pull request is ready, I'll request review from you.

[Copilot]

@mondoreale I've opened a new pull request, #3315, to work on those changes. Once the pull request is ready, I'll request review from you.

[Copilot]

@mondoreale I've opened a new pull request, #3316, to work on those changes. Once the pull request is ready, I'll request review from you.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ mondoreale
❌ Copilot
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[Copilot]

Pull request overview

Copilot reviewed 166 out of 168 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 166 out of 168 changed files in this pull request and generated no new comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.