Skip to content

[ST] Kafka Rebalance ST #2181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jankalinic wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[ST] Kafka Rebalance ST #2181

jankalinic wants to merge 3 commits into from

Conversation

@jankalinic
Copy link
Contributor

@jankalinic jankalinic commented Dec 10, 2025

This PR adds a systemtest for a rebalance feature, deploying Kafka with CC and KafkaRebalance CRs, and using Console UI to verify data and approval of the generated proposals.

@jankalinic jankalinic self-assigned this Dec 10, 2025
@jankalinic jankalinic added do not merge Do not merge just yet. Work is still in progress ready for review Pull request is ready for a static review labels Dec 10, 2025
@jankalinic
Copy link
Contributor Author

jankalinic commented Dec 10, 2025

/systemtests run --profile=regression --retry-count=0

@MikeEdgar MikeEdgar added this to the 0.11.0 milestone Dec 10, 2025
MikeEdgar
MikeEdgar reviewed Dec 11, 2025
View reviewed changes
Copy link
Member

@MikeEdgar MikeEdgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just the Sonar nit. I assume you're still looking at the test failures.

@jankalinic
Copy link
Contributor Author

jankalinic commented Jan 6, 2026

/systemtests run --profile=regression --retry-count=1

@jankalinic
Copy link
Contributor Author

jankalinic commented Jan 12, 2026

/systemtests run --profile=regression --retry-count=1

@jankalinic
Copy link
Contributor Author

jankalinic commented Jan 13, 2026

6/8 ST workflows passed. The two died on runtime issue. Re-triggering should solve this issue.

@jankalinic
Copy link
Contributor Author

jankalinic commented Jan 13, 2026

/systemtests run --testcase=ConsumerST --retry-count=1

@jankalinic
Copy link
Contributor Author

jankalinic commented Jan 13, 2026

/systemtests run --testcase=ConsumerST --retry-count=0

@jankalinic
Copy link
Contributor Author

jankalinic commented Jan 14, 2026

/systemtests run --testcase=ConsumerST --retry-count=0

@jankalinic
Copy link
Contributor Author

jankalinic commented Jan 15, 2026

/systemtests run --testcase=ConsumerST --retry-count=0

@MikeEdgar
Copy link
Member

MikeEdgar commented Jan 15, 2026

It seems like ${{ env.ARTIFACTS_RUN_ID }} isn't available in the job? I think the other download action had some internal logic to find it somehow. Should Get previously built artifacts be moved from generate-matrix to run-systemtests ?

@jankalinic
Copy link
Contributor Author

jankalinic commented Jan 15, 2026

Yes i've just noticed that the env is missing. GITHUB_ENV is job scoped (thought it was workflow scoped), so i need to do that. Thanks!

@jankalinic
Copy link
Contributor Author

jankalinic commented Jan 15, 2026

/systemtests run --testcase=ConsumerST --retry-count=0

@MikeEdgar
Copy link
Member

MikeEdgar commented Jan 15, 2026

It might need a PAT to download: https://github.com/actions/download-artifact?tab=readme-ov-file#download-artifacts-from-other-workflow-runs-or-repositories

Do you want to add it to this PR and it can be tested right away?

@jankalinic
Copy link
Contributor Author

jankalinic commented Jan 15, 2026 •
edited
Loading

Oh, for some reason i thought i read the docs saying that if the token is not specified the one from envs would be used. I'll add it here in that case.

@jankalinic
Copy link
Contributor Author

jankalinic commented Jan 16, 2026

/systemtests run --testcase=ConsumerST --retry-count=0

@MikeEdgar
Copy link
Member

MikeEdgar commented Jan 16, 2026

I forgot the systemtests workflow runs with the main version, so I guess changes in the PR won't work and it needs to be merged first 😢

@jankalinic
Copy link
Contributor Author

jankalinic commented Jan 16, 2026

Yea me too, but some changes to the gha do work though, i just don't remember which.

@jankalinic
Copy link
Contributor Author

jankalinic commented Jan 16, 2026

/systemtests run --testcase=ConsumerST --retry-count=0

1 similar comment
@jankalinic
Copy link
Contributor Author

jankalinic commented Jan 16, 2026

/systemtests run --testcase=ConsumerST --retry-count=0

@MikeEdgar
Copy link
Member

MikeEdgar commented Jan 16, 2026

Darn... this isn't needed with the download action:

- name: Extract Images
  run: |
    unzip streamshub-images.zip

@jankalinic
Copy link
Contributor Author

jankalinic commented Jan 16, 2026

I will try this whole setup on my fork repo to avoid extra PRs, i don't think just removing unzip like that will work. The workflow action should download it to a path from which it may be necessary to move the tgz.

@MikeEdgar
Copy link
Member

MikeEdgar commented Jan 16, 2026

I will try this whole setup on my fork repo to avoid extra PRs, i don't think just removing unzip like that will work. The workflow action should download it to a path from which it may be necessary to move the tgz.

It should work, those are the steps in the playwright workflow. The download unzips it.

- name: Download Images
  uses: actions/download-artifact@v7
  with:
    name: streamshub-images

- name: Setup Minikube Environment
  uses: ./.github/actions/setup-minikube
  with:
    MEM: 8g
    CPUS: 2

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 16, 2026

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jankalinic
Copy link
Contributor Author

jankalinic commented Jan 16, 2026

/systemtests run --testcase=ConsumerST --retry-count=0

@streamshub-bot
Copy link

streamshub-bot commented Jan 16, 2026

❌ Systemtests run finished - failure ❌

Test Summary:

  • TOTAL: 22
  • PASS: 15
  • FAIL: 7
  • SKIP: 0

Used parameters:

  • TEST_CASE: ConsumerST
  • PROFILE:
  • INSTALL_TYPE: olm
  • RETRY_COUNT: 0
  • ENVS:

Test Failures:

  • com.github.streamshub.systemtests.consumers.ConsumerST#testResetConsumerOffsetAllTopicsAllPartitions(int
  • ResetOffsetType
  • ResetOffsetDateTimeType
  • String)[1]
  • com.github.streamshub.systemtests.consumers.ConsumerST#testResetConsumerOffsetAllTopicsAllPartitions(int
  • ResetOffsetType
  • ResetOffsetDateTimeType
  • String)[3]
  • com.github.streamshub.systemtests.consumers.ConsumerST#testResetConsumerOffsetAllTopicsAllPartitions(int
  • ResetOffsetType
  • ResetOffsetDateTimeType
  • String)[4]
  • com.github.streamshub.systemtests.consumers.ConsumerST#testResetConsumerOffsetAllTopicsAllPartitions(int
  • ResetOffsetType
  • ResetOffsetDateTimeType
  • String)[5]
  • com.github.streamshub.systemtests.consumers.ConsumerST#testResetConsumerOffsetAllTopicsAllPartitions(int
  • ResetOffsetType
  • ResetOffsetDateTimeType
  • String)[6]
  • com.github.streamshub.systemtests.consumers.ConsumerST#testResetConsumerOffsetAllTopicsAllPartitions(int
  • ResetOffsetType
  • ResetOffsetDateTimeType
  • String)[7]
  • com.github.streamshub.systemtests.consumers.ConsumerST#testResetConsumerOffsetAllTopicsAllPartitions(int
  • ResetOffsetType
  • ResetOffsetDateTimeType
  • String)[8]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MikeEdgar MikeEdgar MikeEdgar left review comments

@alexcreasy alexcreasy Awaiting requested review from alexcreasy

@hemahg hemahg Awaiting requested review from hemahg

At least 1 approving review is required to merge this pull request.

Assignees

@jankalinic jankalinic

Labels

do not merge Do not merge just yet. Work is still in progress ready for review Pull request is ready for a static review

Projects

None yet

Milestone

0.11.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jankalinic @MikeEdgar @streamshub-bot