Skip to content

Conversation

@kamilchociej
Copy link

@kamilchociej kamilchociej commented Jan 16, 2025

πŸ“‹ Type of the Changes

  • Breaking change
  • Non-breaking change
  • Bug fix / minor change

πŸ›  Changes being made

StreamX Platform deployment preparation

βœ… Checklist

  • My code follows the code standards of this project
  • Changed code is covered with unit tests
  • I have updated READMEs and java docs (if applicable)

@kamilchociej kamilchociej marked this pull request as ready for review January 17, 2025 10:32
@kamilchociej kamilchociej requested a review from a team as a code owner January 17, 2025 10:32
@kamilchociej kamilchociej marked this pull request as draft January 17, 2025 10:36
@@ -0,0 +1,5 @@
export STREAMX_TOKEN_PIM=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

local should be default from .env file, that is overridden by sh script for cloud deployment.
https://quarkus.io/guides/images/config-sources.png

environment:
# local test domain, see readme
STREAMX_BLUEPRINTS_SITEMAP-GENERATOR-PROCESSING-SERVICE_BASE-URL: "http://puresight.127.0.0.1.nip.io"
STREAMX_BLUEPRINTS_SITEMAP-GENERATOR-PROCESSING-SERVICE_BASE-URL: "http://puresight.${STREAMX_INGRESS_IP}.nip.io"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could configure whole domains, so that many people can deploy on the single cluster in multiple namespaces?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants