-
Notifications
You must be signed in to change notification settings - Fork 0
DXP-2486 Add streamx run, stream and batch commands for StreamX 2.0 (and remove streamx publish/unpublish/cloud/dev/init commands for now) #219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
stan-r-ds
wants to merge
32
commits into
main
Choose a base branch
from
DXP-2486-add-run-stream-and-batch-commands-for-streamx-2.0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
243064b
DXP-2486 Add streamx run, stream and batch commands for StreamX 2.0 (β¦
stan-r-ds eb63811
mockito
stan-r-ds 288ccf8
java 21
stan-r-ds e8ac81a
add missing validation
stan-r-ds 9761683
Remove Resource class
stan-r-ds 46a6874
Restore banner
stan-r-ds 74f6c6d
Remove unnecessary plugin
stan-r-ds cad43e5
Use cli source
stan-r-ds c8ca778
Increase test coverage
stan-r-ds 9776c77
Use jvm
stan-r-ds dca7a18
Use temurin
stan-r-ds 18fdda4
Move test file, add test for default values
stan-r-ds f08a25d
Better newline diff comparison
stan-r-ds 16501c8
Use native
stan-r-ds dd8a24b
restore {}
stan-r-ds 0b9fcd3
Improve handling of ByteBuffer fields
stan-r-ds 2145fc8
CloudEventBuilder fixes
stan-r-ds 403fd23
fixes
stan-r-ds d3f7eae
fix codestyle
stan-r-ds 1f13cc6
Small fix
stan-r-ds 811cab5
Use new streamx-service-mesh version
stan-r-ds 6b6e62d
Don't use native
stan-r-ds ec213a6
Minor fixes
stan-r-ds c6eba11
add debug logging
stan-r-ds cd8b684
Remove repository volume
stan-r-ds 976a3d6
Volumes cleanup
stan-r-ds 0158222
Temporarily allow releasing preview on demand
stan-r-ds 58337de
Temporarily embed releasing preview on demand into PR CI
stan-r-ds 8e1100e
Make release preview to use specific branch
stan-r-ds 3ba20b4
Restore recent changes regarding preview releasing
stan-r-ds ee83d91
Rename json.paths.to.encode.to.base64 to json.fields.as-base64
stan-r-ds a0b9cc6
Formatting agnostic verification
stan-r-ds File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,14 +25,14 @@ public OsTerminalCommandRunner() { | |
| } | ||
|
|
||
| public ShellProcess run(String command) { | ||
| logger.info("Running terminal command: " + command); | ||
| ProcessBuilder processBuilder = osCommand.create(command); | ||
| try { | ||
| ShellProcess shellProcess = ShellProcess.run(processBuilder); | ||
| logger.info("Terminal command: '" + command + "' started"); | ||
| processes.add(shellProcess); | ||
| return shellProcess; | ||
| } catch (IOException e) { | ||
| logger.info("Error running terminal command: " + command); | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Deduplicate log messages for success |
||
| throw new RuntimeException(e); | ||
| } | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove any "/../" from the logged path