Skip to content

Conversation

@Jason3S
Copy link
Contributor

@Jason3S Jason3S commented May 7, 2025

Breaking: Minimal node version is 20.

@Jason3S Jason3S merged commit 280c047 into main May 7, 2025
9 checks passed
@Jason3S Jason3S deleted the dev-cspell branch May 7, 2025 07:30
@ADTC
Copy link

ADTC commented May 7, 2025

@Jason3S what are the breaking changes?! My system auto-updated to v9 because of npx -y and now my entire custom dictionary (which I use CLI to generate by searching the entire repo) has gone whack. Words that were already in default dictionary are now added in custom dictionary, and words that should be in the custom dictionary are removed, causing the VSCode extension to start complaining that they are unknown words.

I'm switching to npx -y cspell-cli@8 until we have more details on what's going on. This is really bad. You just have ⚠ BREAKING CHANGES in the Release page, but no explanation of what changed.

PS: My node is v20.17.0.

@ADTC
Copy link

ADTC commented May 7, 2025

Very confused btw, because the diff between v8 and v9 doesn't show much other than some version number changes.

Is it one of the dependencies that change the actual behavior of the CLI drastically? I do see a lot of dependency changes in package-lock.json.

@Jason3S
Copy link
Contributor Author

Jason3S commented May 7, 2025

@ADTC,

Sorry for the issue. I'm guessing you are using the British English dictionary. For licensing reasons we had to move away from the old dictionary because of the LGPL license to one with an MIT license.

@ADTC
Copy link

ADTC commented May 7, 2025

Yes it's a project that uses British English. Why are there so many words being ignored now like ASEAN for example. cSpell CLI v9 removes it from the generated custom list, and then VSCode starts complaining that it's an unknown word. What's the solution there?

@Jason3S
Copy link
Contributor Author

Jason3S commented May 7, 2025

@ADTC,

The issues is that the dictionaries and the extension are our of sync. The dictionary extension CSpell Bundled Dictionaries - Code Spell Checker is updated frequently to help keep the VSCode Spell Checker's dictionaries up to date.

@ADTC
Copy link

ADTC commented May 8, 2025

I see, I think I only have the main extension, and not this additional extension. I will give this additional extension a try and see if v9 will work for me.

Thank you for clarifying.

@Jason3S
Copy link
Contributor Author

Jason3S commented May 8, 2025

@ADTC,

I have updated the dictionary to address most of the missing words. I'll make a release soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants